Skip to content

Commit 34533d7

Browse files
committed
Merge pull request #24 from courseload/drop-peer-dependency
Drop React from peerDependency and rely on passing it in.
2 parents 803325d + 2170f25 commit 34533d7

5 files changed

Lines changed: 16 additions & 12 deletions

File tree

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ getting warnings in the console as your app renders.
2323

2424
```js
2525
var a11y = require('react-a11y');
26-
if (ENV === 'development') a11y();
26+
if (ENV === 'development') a11y(React);
2727
```
2828

2929
You probably don't want to call it if you're in production, and better
@@ -32,6 +32,5 @@ yet, alias the module to nothing with webpack in production.
3232
If you want it to throw errors instead of just warnings:
3333

3434
```
35-
a11y({throw: true});
35+
a11y(React, {throw: true});
3636
```
37-

lib/__tests__/index-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var React = require('react');
22
var assert = require('assert');
3-
require('../index')();
3+
require('../index')(React);
44
var assertions = require('../assertions');
55

66
var k = () => {};

lib/assertions.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
var React = require('react');
1+
var React;
2+
3+
exports.setReact = function(R) {
4+
React = R;
5+
};
26

37
var INTERACTIVE = {
48
'button': true,

lib/index.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
var React = require('react');
21
var assertions = require('./assertions');
32

43
var assertAccessibility = (tagName, props, children) => {
@@ -30,7 +29,12 @@ var warn = (id, msg) => {
3029
};
3130

3231
var nextId = 0;
33-
module.exports = (options) => {
32+
module.exports = (React, options) => {
33+
if (!React && !React.createElement) {
34+
throw new Error('Missing parameter: React');
35+
}
36+
assertions.setReact(React);
37+
3438
var _createElement = React.createElement;
3539
var log = options && options.throw ? error : warn;
3640
React.createElement = function (type, _props, ...children) {

package.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,10 @@
3333
"karma-sourcemap-loader": "^0.3.2",
3434
"karma-webpack": "^1.3.1",
3535
"mocha": "^2.0.1",
36-
"react": "0.12.x",
36+
"react": "^0.12 || ^0.13",
3737
"rf-release": "0.4.0",
3838
"webpack": "^1.4.13"
3939
},
40-
"peerDependencies": {
41-
"react": "^0.12 || ^0.13"
42-
},
4340
"tags": [
4441
"accessibility",
4542
"react",
@@ -50,4 +47,4 @@
5047
"react",
5148
"a11y"
5249
]
53-
}
50+
}

0 commit comments

Comments
 (0)