Merge pull request #2 from cannona/master

Accepts images with non-empty alt attributes as labels for clickable elements

Author: ryanflorence

lib/__tests__/index-test.js

@@ -58,6 +58,18 @@ describe('props', () => {
           <div onClick={k}><span><span>foo</span></span></div>;
         });
       });
+
+      it('does not warn if there is an image with an alt attribute', () => {
+        doNotExpectWarning(assertions.props.onClick.NO_LABEL.msg, () => {
+          <div onClick={k}><img src="#" alt="Foo"/></div>;
+        });
+      });
+      
+      it('warns if there is an image with an empty alt attribute', () => {
+        expectWarning(assertions.props.onClick.NO_LABEL.msg, () => {
+          <div onClick={k}><img src="#" alt=""/></div>;
+        });
+      });
     });
 
     describe('when role="button"', () => {

lib/assertions.js

@@ -25,6 +25,8 @@ var hasChildTextNode = (props, children) => {
       return;
     else if (typeof child === 'string')
       hasText = true;
+    else if (child.type === 'img' && child.props.alt)
+      hasText = true;
     else if (child.props.children)
       hasText = hasChildTextNode(child.props, child.props.children);
   });
@@ -56,6 +58,7 @@ exports.props = {
         return (
           props['aria-label'] ||
           props['aria-labelled-by'] ||
+          (tagName === 'img' && props.alt) ||
           hasChildTextNode(props, children)
         );
       }