fix(gh-workflow): skip comment when push directly#5853
Closed
awxiaoxian2020 wants to merge 1 commit into
Closed
Conversation
Size changesDetails📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
awxiaoxian2020
commented
Apr 1, 2023
| with: | ||
| workflow: analyze.yml | ||
| branch: ${{ github.event.pull_request.base.ref }} | ||
| branch: ${{ github.event.pull_request.base.ref || 'main' }} |
Contributor
Author
There was a problem hiding this comment.
When we push directly, we use main branch.
| name: analysis_comment.txt | ||
| path: .next/analyze/__bundle_analysis_comment.txt | ||
|
|
||
| number: |
Contributor
Author
There was a problem hiding this comment.
We shouldn't upload the pr_number when we push directly. So I split a new job and add a condition in order to run it on pull_request only.
| if: > | ||
| ${{ github.event.workflow_run.event == 'pull_request' && | ||
| github.event.workflow_run.conclusion == 'success' }} | ||
| github.event.workflow_run.workflows.event_name == 'pull_request' && github.event.workflow_run.workflows.conclusion == 'success' |
Contributor
Author
There was a problem hiding this comment.
This is the key about this problem.
We should use github.event.workflow_run.workflows.event_name instead of github.event.workflow_run.event.
And we shouldn't use the ${{}}, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5801.
It works fine in zh-hans repo workflow.
I will explain my changes in code review.