Skip to content

Better config #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
el-rabies merged 2 commits into from
Apr 9, 2026
Merged

Better config #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bcea10
Added automatic new version detection to homepage
el-rabies Apr 9, 2026
5f9bf84
null protection
el-rabies Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions projects/website-angular/src/app/home-page/home-stats/home-stats.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { MatIcon } from "@angular/material/icon";
import { CarouselComponent } from "../../reactome-components/carousel/carousel.component";
import { StatsService } from '../../../services/stats.service';
import { APP_CONFIG } from '../../../config/config'; // NEW import
import { GeneralService } from 'projects/pathway-browser/src/app/services/general.service';

interface Stats {
human_pathways: number;
Expand All @@ -23,6 +24,7 @@ interface Stats {
})
export class HomeStatsComponent {
private statsService = inject(StatsService);
private generalService = inject(GeneralService);

version: string = '';
releaseDate: Date = new Date();
Expand All @@ -40,8 +42,7 @@ export class HomeStatsComponent {
}

getVersionAndDate () {
// Use APP_CONFIG instead of dynamic JSON import
this.version = APP_CONFIG.version.releaseNumber;
this.version = 'V' + (this.generalService.version.value() ?? APP_CONFIG.version.releaseNumber).toString();
this.releaseDate = new Date(APP_CONFIG.version.releaseDate);
this.fetchStats();
}
Expand Down
9 changes: 0 additions & 9 deletions projects/website-angular/src/config/config.json
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions projects/website-angular/src/config/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
export const APP_CONFIG = {
// app-level version info
version: {
label: 'V95',
releaseNumber: '95',
releaseDate: '2025-12-09'
releaseNumber: '96',
releaseDate: '2026-04-01'
},

// canonical site base / download base (choose prod by default)
Expand Down
62 changes: 0 additions & 62 deletions projects/website-angular/src/config/external-links.json
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion projects/website-angular/src/services/stats.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { isPlatformBrowser } from '@angular/common';
import { HttpClient } from '@angular/common/http';
import { Observable, map, catchError, of, timeout } from 'rxjs';
import { APP_CONFIG } from '../config/config'; // NEW import
import { GeneralService } from 'projects/pathway-browser/src/app/services/general.service';

export interface ReactomeStats {
pathways: number;
Expand All @@ -24,13 +25,14 @@ interface RawStatItem {
export class StatsService {
private http = inject(HttpClient);
private platformId = inject(PLATFORM_ID);
private generalService = inject(GeneralService);
private isBrowser = isPlatformBrowser(this.platformId);

/**
* Get the current Reactome version from APP_CONFIG
*/
async getVersion(): Promise<string> {
return APP_CONFIG.version.releaseNumber;
return (this.generalService.version.value() ?? APP_CONFIG.version.releaseNumber).toString();
}

/**
Expand Down
Loading