Skip to content

Commit 8cf7394

Browse files
Remove references.txt and categories.txt from repo
These files are now baked into the illustration-validator Docker image. Updated the download script, CI workflow, and README accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent bc5c36b commit 8cf7394

5 files changed

Lines changed: 1 addition & 53 deletions

File tree

.github/workflows/validate.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,10 @@ jobs:
1313
- name: Validate icons and EHLDs
1414
run: |
1515
docker run --rm \
16-
-v ${{ github.workspace }}/references.txt:/app/references.txt \
17-
-v ${{ github.workspace }}/categories.txt:/app/categories.txt \
1816
-v ${{ github.workspace }}/icons:/data/icons \
1917
-v ${{ github.workspace }}/ehld:/data/ehld \
2018
public.ecr.aws/reactome/illustration-validator:latest \
2119
java -jar ./target/illustration-validator-jar-with-dependencies.jar \
22-
-r /app/references.txt \
23-
-c /app/categories.txt \
2420
-e false \
2521
-d /data/icons \
2622
-s /data/ehld

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ SVG icons and EHLD diagrams for [Reactome](https://reactome.org/) pathway diagra
77
- `icons/` - SVG icons and XML metadata files (R-ICO-XXXXXX.svg and .xml)
88
- `ehld/` - EHLD diagram SVGs (R-HSA-XXXXXX.svg)
99
- `download_illustrations.py` - Script to download icons and EHLDs from Figma and validate them
10-
- `references.txt` - Valid reference database names for the icon validator
11-
- `categories.txt` - Valid category names for the icon validator
10+
- `VERSION` - Current release version number
1211

1312
## Prerequisites
1413

categories.txt

Lines changed: 0 additions & 8 deletions
This file was deleted.

download_illustrations.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@
3333
SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
3434
ICONS_DIR = os.path.join(SCRIPT_DIR, "icons")
3535
EHLD_DIR = os.path.join(SCRIPT_DIR, "ehld")
36-
REFERENCES_FILE = os.path.join(SCRIPT_DIR, "references.txt")
37-
CATEGORIES_FILE = os.path.join(SCRIPT_DIR, "categories.txt")
3836

3937
VALIDATOR_IMAGE = "public.ecr.aws/reactome/illustration-validator:latest"
4038

@@ -232,21 +230,12 @@ def validate(do_icons, do_ehlds):
232230
print("VALIDATING")
233231
print("=" * 60)
234232

235-
for f in [REFERENCES_FILE, CATEGORIES_FILE]:
236-
if not os.path.exists(f):
237-
print(f"Error: {f} not found. Cannot run validation.")
238-
return False
239-
240233
cmd = [
241234
"docker", "run", "--rm",
242-
"-v", f"{REFERENCES_FILE}:/app/references.txt",
243-
"-v", f"{CATEGORIES_FILE}:/app/categories.txt",
244235
]
245236

246237
validator_args = [
247238
"java", "-jar", "./target/illustration-validator-jar-with-dependencies.jar",
248-
"-r", "/app/references.txt",
249-
"-c", "/app/categories.txt",
250239
"-e", "false",
251240
]
252241

references.txt

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)