Skip to content

Commit 18bc5b2

Browse files
committed
Add a workaround for git describe not supporting tag+count without hash
1 parent 448fd52 commit 18bc5b2

3 files changed

Lines changed: 16 additions & 7 deletions

File tree

Docker/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ RUN wget https://downloads.sourceforge.net/reactos/RosBE-Unix-2.2.1.tar.bz2 \
3232
&& rm -rf RosBE-Unix-2.2.1
3333

3434
RUN git clone https://github.com/reactos/Release_Engineering \
35-
3635
&& mv Release_Engineering/Release_* /usr/local/bin \
3736
&& rm -rf Release_Engineering
3837

Release_Configure

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,12 @@ else
4646
git checkout "${branch_name}" || exit 1
4747
fi
4848

49-
# Get the suffix from Git if none was entered.
49+
# Get the version from Git if none was entered.
5050
if [ "${version}" = "" ]; then
51-
version=`git describe --abbrev=0`
51+
# Output something like '0.4.15-4-ge1e96bf467b5ea'
52+
version_with_hash=`git describe --always`
53+
# Extract the part before the last dash to ignore the commit hash
54+
version=${version_with_hash%-*}
5255
fi
5356

5457
# Write the config file

Release_ISOs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,20 @@ if [ "$ROS_ARCH" = "" ]; then
1313
exit 1
1414
fi
1515

16+
if [ "$ROS_ARCH" = "i386" ]; then
17+
ROS_PRETTY_ARCH="x86"
18+
else
19+
ROS_PRETTY_ARCH="$ROS_ARCH"
20+
fi
21+
22+
1623
# Constants
1724
ROOTDIR="$PWD"
1825
OUTPUTDIR="output-MinGW-i386"
19-
BOOTCDISO="ReactOS-${version}-${ROS_ARCH}.iso"
20-
BOOTCDZIP="ReactOS-${version}-${ROS_ARCH}-iso.zip"
21-
LIVECDISO="ReactOS-${version}-${ROS_ARCH}-live.iso"
22-
LIVECDZIP="ReactOS-${version}-${ROS_ARCH}-live.zip"
26+
BOOTCDISO="ReactOS-${version}-${ROS_PRETTY_ARCH}.iso"
27+
BOOTCDZIP="ReactOS-${version}-${ROS_PRETTY_ARCH}-iso.zip"
28+
LIVECDISO="ReactOS-${version}-${ROS_PRETTY_ARCH}-live.iso"
29+
LIVECDZIP="ReactOS-${version}-${ROS_PRETTY_ARCH}-live.zip"
2330

2431
# Start from a clean state
2532
rm -f "${ROOTDIR}/${BOOTCDZIP}"

0 commit comments

Comments
 (0)