Skip to content

Commit 37ba99e

Browse files
committed
[MASTER][WORKER] Don't build and upload livecd artifacts anymore (#15)
The ReactOS livecd artifact is deprecated since commit reactos/reactos@b2e33f2 and now, the bootcd contains the functionality of both the Setup and the old livecd. In addition, the "livecd" build target will be renamed and repurposed in the future.
1 parent 0658450 commit 37ba99e

3 files changed

Lines changed: 4 additions & 25 deletions

File tree

master/master.cfg

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ bs_git = steps.Git(repourl='https://github.com/reactos/reactos.git', mode='full'
198198
bs_clean = steps.ShellCommand(name="clean", command=["bash", scripts_root + "clean"], description=["cleaning"], descriptionDone=["clean"], haltOnFailure=True)
199199
bs_prepare_source = steps.ShellCommand(name="prepare_source", command=["bash", scripts_root + "prepare_source", util.WithProperties("%(id:-)s")], description=["preparing source"], descriptionDone=["prepared source"], haltOnFailure=True)
200200
bs_bootcd = steps.Compile(name="bootcd", command=["bash", scripts_root + "build_reactos", "bootcd"], warningPattern="^(.*warning[: ].*|.*error[: ].*)", description=["BootCD"], descriptionDone=["BootCD"])
201-
bs_livecd = steps.Compile(name="livecd", command=["bash", scripts_root + "build_reactos", "livecd"], warningPattern="^(.*warning[: ].*|.*error[: ].*)", description=["LiveCD"], descriptionDone=["LiveCD"])
202201
bs_get_suffix = steps.SetPropertyFromCommand(command=["bash", scripts_root + "get_suffix"], property="suffix")
203202
bs_upload_iso = steps.ShellCommand(name="uploadiso", command=["bash", scripts_root + "uploadiso"], description=["uploading"], descriptionDone=["uploaded"])
204203
bs_submit_results = steps.ShellCommand(name="submit_results", command=["bash", scripts_root + "submit_result", util.WithProperties('%(buildnumber)s'), util.WithProperties('%(reason:-)s'), util.WithProperties('%(id:-)s')], description=["submitting results"], descriptionDone=["submit results"])
@@ -271,7 +270,6 @@ Build_GCCLin_x86.addStep(bs_git)
271270
Build_GCCLin_x86.addStep(bs_prepare_source)
272271
Build_GCCLin_x86.addStep(make_bs_configure())
273272
Build_GCCLin_x86.addStep(bs_bootcd)
274-
Build_GCCLin_x86.addStep(bs_livecd)
275273
Build_GCCLin_x86.addStep(make_bs_regtestcd("-DENABLE_ROSTESTS=1"))
276274
Build_GCCLin_x86.addStep(bs_get_suffix)
277275
Build_GCCLin_x86.addStep(make_bs_trigger("Build GCCLin_x86 regtestcd done"))
@@ -283,7 +281,6 @@ Build_GCCLin_x86_Release.addStep(bs_git)
283281
Build_GCCLin_x86_Release.addStep(bs_prepare_source)
284282
Build_GCCLin_x86_Release.addStep(make_bs_configure("-DCMAKE_BUILD_TYPE=Release"))
285283
Build_GCCLin_x86_Release.addStep(bs_bootcd)
286-
Build_GCCLin_x86_Release.addStep(bs_livecd)
287284
Build_GCCLin_x86_Release.addStep(bs_upload_iso)
288285

289286
Build_GCCWin_x86 = util.BuildFactory();
@@ -292,15 +289,13 @@ Build_GCCWin_x86.addStep(bs_git)
292289
Build_GCCWin_x86.addStep(bs_prepare_source)
293290
Build_GCCWin_x86.addStep(make_bs_configure("-DENABLE_ROSAPPS=1", "-DENABLE_ROSTESTS=1"))
294291
Build_GCCWin_x86.addStep(bs_bootcd)
295-
Build_GCCWin_x86.addStep(bs_livecd)
296292

297293
Build_MSVC_x86 = util.BuildFactory();
298294
Build_MSVC_x86.addStep(bs_clean)
299295
Build_MSVC_x86.addStep(bs_git)
300296
Build_MSVC_x86.addStep(bs_prepare_source)
301297
Build_MSVC_x86.addStep(make_bs_configure())
302298
Build_MSVC_x86.addStep(bs_bootcd)
303-
Build_MSVC_x86.addStep(bs_livecd)
304299
Build_MSVC_x86.addStep(bs_upload_iso)
305300

306301
Build_MSVC_x64 = util.BuildFactory();
@@ -309,7 +304,6 @@ Build_MSVC_x64.addStep(bs_git)
309304
Build_MSVC_x64.addStep(bs_prepare_source)
310305
Build_MSVC_x64.addStep(make_bs_configure())
311306
Build_MSVC_x64.addStep(bs_bootcd)
312-
Build_MSVC_x64.addStep(bs_livecd)
313307
Build_MSVC_x64.addStep(bs_build_rostests)
314308
Build_MSVC_x64.addStep(bs_get_suffix)
315309
Build_MSVC_x64.addStep(make_bs_trigger("Build MSVC_x64 rostests done"))

worker/README

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ ReactOS BuildBot Build Scripts
33

44
Some possible usage scenarios for these scripts:
55

6-
* Plainbot: Builds a Boot-CD, Live-CD, Test-CD, triggers a Testbot for testing it and uploads the created ISO file.
6+
* Plainbot: Builds a Boot-CD, a Test-CD, and triggers a Testbot for testing it and uploads the created ISO files.
77
If a patch ID is given, the patch is applied first, but the build is not uploaded.
88
* Testbot: Triggered by a Plainbot, performs regression testing on a Test-CD and submits the results.
99
Generally, this one is implemented as an independent builder to not block the Plainbot doing its other tasks. But its steps can also be integrated inside a Plainbot.
@@ -20,7 +20,6 @@ Git update *
2020
prepare_source *
2121
configure *
2222
build_reactos bootcd *
23-
build_reactos livecd *
2423
regtestcd *
2524
Trigger Testbot *
2625
vbox_clean / vmware_clean *

worker/uploadiso

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22
# ReactOS BuildBot Build Scripts
3-
# uploadiso - Publish the created Boot-CD and Live-CD on iso.reactos.org in compressed files.
3+
# uploadiso - Publish the created Boot-CD on iso.reactos.org in compressed files.
44
source ../../config.inc
55

66
# Some config for accessing iso.reactos.org, but common to all builders
@@ -18,20 +18,18 @@ esac
1818

1919
# Check what files we have.
2020
[ -f "$ROS_OUTPUT/bootcd.iso" ] && BOOTCD=1 || BOOTCD=0
21-
[ -f "$ROS_OUTPUT/livecd.iso" ] && LIVECD=1 || LIVECD=0
2221

23-
if [ $BOOTCD -eq 0 -a $LIVECD -eq 0 ]; then
22+
if [ $BOOTCD -eq 0 ]; then
2423
echo "* There are no ISO files to process."
2524
exit 2
2625
fi
2726

2827
# Rsync them onto the file server.
2928
BOOT=reactos-bootcd-$REVISION_SUFFIX-$UPLOAD_SUFFIX
30-
LIVE=reactos-livecd-$REVISION_SUFFIX-$UPLOAD_SUFFIX
3129

3230
echo "* Rsyncing ISO files onto iso.reactos.org..."
3331
cd $ROS_OUTPUT
34-
rsync --stats -e "ssh -l $UPLOAD_USER -i $UPLOAD_KEY" -rtvz --include=bootcd.iso --include=livecd.iso --exclude=* . $UPLOAD_HOST:$UPLOAD_TEMPDIR || exit 1
32+
rsync --stats -e "ssh -l $UPLOAD_USER -i $UPLOAD_KEY" -rtvz --include=bootcd.iso --exclude=* . $UPLOAD_HOST:$UPLOAD_TEMPDIR || exit 1
3533
echo -e "* Done.\n"
3634

3735
# Remotely compress them on the file server and update symbolic links.
@@ -46,15 +44,3 @@ if [ $BOOTCD ]; then
4644
else
4745
echo "* There is no $BOOT to compress."
4846
fi
49-
50-
if [ $LIVECD ]; then
51-
echo "* Remotely compressing $LIVE..."
52-
ssh $SSHOPTS "ln $UPLOAD_TEMPDIR/livecd.iso $UPLOAD_TEMPDIR/$LIVE.iso"
53-
ssh $SSHOPTS "7za a -bd -t7z $UPLOAD_TEMPDIR/$LIVE.7z $UPLOAD_TEMPDIR/$LIVE.iso -mx9 | tail -n +4"
54-
ssh $SSHOPTS "rm $UPLOAD_TEMPDIR/$LIVE.iso"
55-
ssh $SSHOPTS "mv $UPLOAD_TEMPDIR/$LIVE.7z $UPLOAD_ISODIR/livecd/"
56-
ssh $SSHOPTS "chmod 0644 $UPLOAD_ISODIR/livecd/$LIVE.7z"
57-
ssh $SSHOPTS "ln -snf $LIVE.7z $UPLOAD_ISODIR/livecd/latest-$UPLOAD_SUFFIX"
58-
else
59-
echo "* There is no $LIVE to compress."
60-
fi

0 commit comments

Comments
 (0)