[WORKER] Upload the bootcdregtest ISOs as well#17
Open
HBelusca wants to merge 2 commits into
Open
Conversation
HBelusca
added a commit
that referenced
this pull request
Apr 29, 2026
These ISOs are uploaded to: https://iso.reactos.org/temp/ ONLINE-709 Uploading the bootcdregtest ISOs are meant to be used only for diagnostics purposes, e.g. if a build crashes on a testbot and provides a given stack trace, one could then download the corresponding test ISO locally and spelunk into the offending module(s) to check what's going on. This is mandatory if the crash happens within a built test module (rostest), since those aren't included by default in the regular uploaded bootcd.
9583fdb to
6a31b2c
Compare
|
Regarding the cleanup: could we just check for old isos (by creation date) and delete them before uploading a new one? |
DarkFire01
approved these changes
Apr 30, 2026
These ISOs are uploaded to: https://iso.reactos.org/temp/ ONLINE-709 Uploading the bootcdregtest ISOs are meant to be used only for diagnostics purposes, e.g. if a build crashes on a testbot and provides a given stack trace, one could then download the corresponding test ISO locally and spelunk into the offending module(s) to check what's going on. This is mandatory if the crash happens within a built test module (rostest), since those aren't included by default in the regular uploaded bootcd.
…before uploading new ones there
6a31b2c to
ff787ce
Compare
HBelusca
commented
Jul 5, 2026
Comment on lines
+55
to
+57
| # Cleanup ISOs/7z archives in the remote /temp/ folder that are older than 1 week. | ||
| echo "* Remotely cleaning old bootcdregtest ISOs..." | ||
| ssh $SSHOPTS "find $UPLOAD_ISODIR/temp/ -mindepth 1 -maxdepth 1 '(' -name \"*.iso\" -o -name \"*.7z\" ')' -type f -mtime +7 -delete" |
Author
There was a problem hiding this comment.
This is the command I came up with, in order to delete ISOs/7z archives in the remote /temp/ directory, if they are older than 1 week.
- I use
mtime(data modified time) because in general on *nix there is no concept of "creation date". Usingctimeinstead would mean I'm looking at the metadata changes, which wasn't my intent. - I use
-mindepth 1 -maxdepth 1in order to explicitly restrict the search to the first level inside this directory -- if there were to be subdirectories inside it, I don't want to recurse inside them. Iirc. these options are gnu-specific... (see https://unix.stackexchange.com/a/298593 and other comments in it). - I use
-deletebecause it's claimed to be faster than piping the result tormcommand (see e.g. thexargscommand examples). However this is a gnu-specific option, and might not be present everywhere (see https://superuser.com/a/1222237 and https://unix.stackexchange.com/questions/167823/finds-exec-rm-vs-delete ). If it were to not work on the machine, then replace-deleteby:-print0 | xargs -0r -n1 rm -f --
Side-note: I tested locally this command by using -mmin option instead of -mtime in order to be able to specify a time amount in minutes (and not in days).
Author
There was a problem hiding this comment.
Note that the "1 week" limit was arbitrarily taken; maybe this needs to be reduced to just a couple of days, or whatever?
Author
|
@tkreuzer @DarkFire01 Could you guys check again the proposed solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These ISOs are uploaded to: https://iso.reactos.org/temp/
JIRA issue: ONLINE-709
Uploading the bootcdregtest ISOs are meant to be used only for diagnostics purposes, e.g. if a build crashes on a testbot and provides a given stack trace, one could then download the corresponding test ISO locally and spelunk into the offending module(s) to check what's going on. This is mandatory if the crash happens within a built test module (rostest), since those aren't included by default in the regular uploaded bootcd.
TODO