Skip to content

[WORKER] Upload the bootcdregtest ISOs as well#17

Open
HBelusca wants to merge 2 commits into
masterfrom
upload_bootcdregtest
Open

[WORKER] Upload the bootcdregtest ISOs as well#17
HBelusca wants to merge 2 commits into
masterfrom
upload_bootcdregtest

Conversation

@HBelusca

@HBelusca HBelusca commented Apr 29, 2026

Copy link
Copy Markdown

These ISOs are uploaded to: https://iso.reactos.org/temp/

JIRA issue: ONLINE-709

Uploading the bootcdregtest ISOs are meant to be used only for diagnostics purposes, e.g. if a build crashes on a testbot and provides a given stack trace, one could then download the corresponding test ISO locally and spelunk into the offending module(s) to check what's going on. This is mandatory if the crash happens within a built test module (rostest), since those aren't included by default in the regular uploaded bootcd.

TODO

HBelusca added a commit that referenced this pull request Apr 29, 2026
These ISOs are uploaded to: https://iso.reactos.org/temp/

ONLINE-709

Uploading the bootcdregtest ISOs are meant to be used only for diagnostics
purposes, e.g. if a build crashes on a testbot and provides a given stack
trace, one could then download the corresponding test ISO locally and
spelunk into the offending module(s) to check what's going on.
This is mandatory if the crash happens within a built test module
(rostest), since those aren't included by default in the regular
uploaded bootcd.
@HBelusca HBelusca force-pushed the upload_bootcdregtest branch from 9583fdb to 6a31b2c Compare April 29, 2026 12:18
@tkreuzer

Copy link
Copy Markdown

Regarding the cleanup: could we just check for old isos (by creation date) and delete them before uploading a new one?

HBelusca added 2 commits July 5, 2026 19:13
These ISOs are uploaded to: https://iso.reactos.org/temp/

ONLINE-709

Uploading the bootcdregtest ISOs are meant to be used only for diagnostics
purposes, e.g. if a build crashes on a testbot and provides a given stack
trace, one could then download the corresponding test ISO locally and
spelunk into the offending module(s) to check what's going on.
This is mandatory if the crash happens within a built test module
(rostest), since those aren't included by default in the regular
uploaded bootcd.
@HBelusca HBelusca force-pushed the upload_bootcdregtest branch from 6a31b2c to ff787ce Compare July 5, 2026 19:41
@HBelusca HBelusca requested a review from cbialorucki July 5, 2026 19:41
Comment thread worker/uploadiso
Comment on lines +55 to +57
# Cleanup ISOs/7z archives in the remote /temp/ folder that are older than 1 week.
echo "* Remotely cleaning old bootcdregtest ISOs..."
ssh $SSHOPTS "find $UPLOAD_ISODIR/temp/ -mindepth 1 -maxdepth 1 '(' -name \"*.iso\" -o -name \"*.7z\" ')' -type f -mtime +7 -delete"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the command I came up with, in order to delete ISOs/7z archives in the remote /temp/ directory, if they are older than 1 week.

Side-note: I tested locally this command by using -mmin option instead of -mtime in order to be able to specify a time amount in minutes (and not in days).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the "1 week" limit was arbitrarily taken; maybe this needs to be reduced to just a couple of days, or whatever?

@HBelusca

HBelusca commented Jul 5, 2026

Copy link
Copy Markdown
Author

@tkreuzer @DarkFire01 Could you guys check again the proposed solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants