Skip to content

Commit 1422f1e

Browse files
committed
Support PHP 8
1 parent f93a15f commit 1422f1e

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ jobs:
1414
- ubuntu-20.04
1515
- windows-2019
1616
php:
17+
- 8.0
1718
- 7.4
1819
- 7.3
1920
- 7.2

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ $ composer require react/child-process:^0.6.1
573573
See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.
574574

575575
This project aims to run on any platform and thus does not require any PHP
576-
extensions and supports running on legacy PHP 5.3 through current PHP 7+ and HHVM.
576+
extensions and supports running on legacy PHP 5.3 through current PHP 8+ and HHVM.
577577
It's *highly recommended to use PHP 7+* for this project.
578578

579579
See above note for limited [Windows Compatibility](#windows-compatibility).

tests/AbstractProcessTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ public function testStartWithExcessiveNumberOfFileDescriptorsWillThrow()
109109
$this->markTestSkipped('Not supported on legacy HHVM');
110110
}
111111

112-
$ulimit = exec('ulimit -n 2>&1');
112+
$ulimit = (int) exec('ulimit -n 2>&1');
113113
if ($ulimit < 1) {
114114
$this->markTestSkipped('Unable to determine limit of open files (ulimit not available?)');
115115
}
116116

117117
$loop = $this->createLoop();
118118

119119
// create 70% (usually ~700) dummy file handles in this parent dummy
120-
$limit = (int)($ulimit * 0.7);
120+
$limit = (int) ($ulimit * 0.7);
121121
$fds = array();
122122
for ($i = 0; $i < $limit; ++$i) {
123123
$fds[$i] = fopen('/dev/null', 'r');

0 commit comments

Comments
 (0)