Mark Server and SecureServer as final

Classes should be used via composition rather than extension.
This reduces our API footprint and avoids future BC breaks by avoiding
exposing its internal assumptions.

Author: clue

README.md

@@ -296,13 +296,13 @@ If you want to typehint in your higher-level protocol implementation, you SHOULD
 use the generic [`ServerInterface`](#serverinterface) instead.
 
 > Advanced usage: Despite allowing any `ServerInterface` as first parameter,
-you SHOULD pass an unmodified `Server` instance as first parameter, unless you
+you SHOULD pass a `Server` instance as first parameter, unless you
 know what you're doing.
 Internally, the `SecureServer` has to set the required TLS context options on
 the underlying stream resources.
 These resources are not exposed through any of the interfaces defined in this
 package, but only through the `React\Stream\Stream` class.
-The unmodified `Server` class is guaranteed to emit connections that implement
+The `Server` class is guaranteed to emit connections that implement
 the `ConnectionInterface` and also extend the `Stream` class in order to
 expose these underlying resources.
 If you use a custom `ServerInterface` and its `connection` event does not

src/SecureServer.php

@@ -52,7 +52,7 @@
  * @see ServerInterface
  * @see ConnectionInterface
  */
-class SecureServer extends EventEmitter implements ServerInterface
+final class SecureServer extends EventEmitter implements ServerInterface
 {
     private $tcp;
     private $encryption;
@@ -96,13 +96,13 @@ class SecureServer extends EventEmitter implements ServerInterface
      * Passing unknown context options has no effect.
      *
      * Advanced usage: Despite allowing any `ServerInterface` as first parameter,
-     * you SHOULD pass an unmodified `Server` instance as first parameter, unless you
+     * you SHOULD pass a `Server` instance as first parameter, unless you
      * know what you're doing.
      * Internally, the `SecureServer` has to set the required TLS context options on
      * the underlying stream resources.
      * These resources are not exposed through any of the interfaces defined in this
      * package, but only through the `React\Stream\Stream` class.
-     * The unmodified `Server` class is guaranteed to emit connections that implement
+     * The `Server` class is guaranteed to emit connections that implement
      * the `ConnectionInterface` and also extend the `Stream` class in order to
      * expose these underlying resources.
      * If you use a custom `ServerInterface` and its `connection` event does not

src/Server.php

@@ -34,7 +34,7 @@
  * @see ServerInterface
  * @see ConnectionInterface
  */
-class Server extends EventEmitter implements ServerInterface
+final class Server extends EventEmitter implements ServerInterface
 {
     private $master;
     private $loop;

tests/SecureServerTest.php

@@ -3,6 +3,7 @@
 namespace React\Tests\Socket;
 
 use React\Socket\SecureServer;
+use React\Socket\Server;
 
 class SecureServerTest extends TestCase
 {
@@ -39,10 +40,10 @@ public function testCloseWillBePassedThroughToTcpServer()
 
     public function testConnectionWillBeEndedWithErrorIfItIsNotAStream()
     {
-        $tcp = $this->getMockBuilder('React\Socket\Server')->disableOriginalConstructor()->setMethods(null)->getMock();
-
         $loop = $this->getMock('React\EventLoop\LoopInterface');
 
+        $tcp = new Server(0, $loop);
+
         $connection = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();
         $connection->expects($this->once())->method('end');
 
@@ -55,10 +56,10 @@ public function testConnectionWillBeEndedWithErrorIfItIsNotAStream()
 
     public function testSocketErrorWillBeForwarded()
     {
-        $tcp = $this->getMockBuilder('React\Socket\Server')->disableOriginalConstructor()->setMethods(null)->getMock();
-
         $loop = $this->getMock('React\EventLoop\LoopInterface');
 
+        $tcp = new Server(0, $loop);
+
         $server = new SecureServer($tcp, $loop, array());
 
         $server->on('error', $this->expectCallableOnce());