Skip to content

Remove content migrated to CLI#219

Merged
chocolatkey merged 5 commits into
developfrom
cli-migration
Apr 30, 2025
Merged

Remove content migrated to CLI#219
chocolatkey merged 5 commits into
developfrom
cli-migration

Conversation

@chocolatkey
Copy link
Copy Markdown
Member

Also, prepare CHANGELOG

@chocolatkey chocolatkey marked this pull request as ready for review April 29, 2025 21:30
Copy link
Copy Markdown
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo in the Markdowns. I bet Copilot would have spotted it, let's see.

EDIT: Nope, disappointed ☹️

Comment thread README.md Outdated
Comment thread CHANGELOG.md Outdated
@mickael-menu mickael-menu requested a review from Copilot April 30, 2025 14:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes legacy server and client code that has now been migrated to the new CLI repository and updates the documentation accordingly.

  • Removed the entire contents of the "cmd/rwp" command, including server routes, client HTTP handlers, caching modules, and supporting helper functions.
  • Updated README and CHANGELOG to point users to the new Readium CLI repository and reflect the changes in the project’s functionality.

Reviewed Changes

Copilot reviewed 21 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cmd/rwp/cmd/serve/* Removed server routing and debugging endpoints.
cmd/rwp/cmd/serve/client/* Removed HTTP client, IP address and authentication helpers.
cmd/rwp/cmd/serve/cache/* Removed caching mechanisms for publications.
cmd/rwp/cmd/serve/api.go, serve.go, etc. Removed legacy API endpoints and server bootstrapping code.
cmd/rwp/cmd/root.go, manifest.go, helpers Removed CLI command definitions and related helper functions.
README.md Updated to direct users to the new Readium CLI repository.
CHANGELOG.md Updated changelog entries to document the removals and new features.
Files not reviewed (4)
  • .github/workflows/release.yml: Language not supported
  • .goreleaser.yaml: Language not supported
  • Dockerfile: Language not supported
  • Makefile: Language not supported
Comments suppressed due to low confidence (2)

README.md:3

  • The updated README directs users to the new CLI repository. Consider ensuring that all references and links are consistently updated across the project documentation.
+**Looking for the `rwp` command-line tools? Checkout the new [https://github.com/readium/cli](Readium CLI) repo!**

CHANGELOG.md:9

  • The changelog entry clearly outlines the removed components and new features; verify that dependent documentation or integration references are also updated to reflect the migration to the CLI.
+### Removed

chocolatkey and others added 2 commits April 30, 2025 14:50
Co-authored-by: Mickaël Menu <mickael.menu@gmail.com>
Co-authored-by: Mickaël Menu <mickael.menu@gmail.com>
@chocolatkey chocolatkey merged commit 022628c into develop Apr 30, 2025
4 checks passed
@chocolatkey chocolatkey deleted the cli-migration branch April 30, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants