Fix blank iframe after remount by setting iframe.src on load#239
Open
sandmor wants to merge 1 commit into
Open
Fix blank iframe after remount by setting iframe.src on load#239sandmor wants to merge 1 commit into
sandmor wants to merge 1 commit into
Conversation
Contributor
|
@chocolatkey I am unable to review this PR ar the moment because I do not have the all the background information relevant to I know this was quite some time ago but would you happen to remember why you picked the former? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #238
The frame managers loaded blob content with
contentWindow.location.replace()and never setiframe.src, so the attribute stayed atabout:blank, provoking later for remount/reparent to restore a blank document while the iframe stayed in the DOM.This fixes it via setting
iframe.src = sourcein FrameManager, FXLFrameManager and WebPubFrameManager.