Skip to content

Avoid duplicate prev/next access keys#1687

Open
Herrtian wants to merge 1 commit into
readthedocs:masterfrom
Herrtian:unique-prev-next-accesskeys
Open

Avoid duplicate prev/next access keys#1687
Herrtian wants to merge 1 commit into
readthedocs:masterfrom
Herrtian:unique-prev-next-accesskeys

Conversation

@Herrtian
Copy link
Copy Markdown

@Herrtian Herrtian commented May 5, 2026

When prev/next buttons are shown in both locations, both the top and footer links currently render the same accesskey values. This keeps the access keys on the footer links and omits them from the duplicate top links when the location is both.

Checks:

  • git diff --check
  • uv run --with pytest --with sphinx --with-editable . pytest tests/test_builders.py::test_prev_next_accesskeys_are_unique_when_buttons_location_is_both
  • PYTHONUTF8=1 uv run --with pytest --with sphinx --with-editable . pytest tests/test_builders.py

Fixes #1057

@Herrtian Herrtian requested a review from a team as a code owner May 5, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated access key of the prev and next buttons when prev_next_buttons_location == 'both'

1 participant