-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Expand file tree
/
Copy pathExplicitReturnRule.swift
More file actions
115 lines (103 loc) · 4.06 KB
/
ExplicitReturnRule.swift
File metadata and controls
115 lines (103 loc) · 4.06 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
import Foundation
import SwiftSyntax
@SwiftSyntaxRule(correctable: true, optIn: true)
struct ExplicitReturnRule: Rule {
var configuration = ExplicitReturnConfiguration()
static let description = RuleDescription(
identifier: "explicit_return",
name: "Explicit Return",
description: "Prefer explicit returns in closures, functions and getters",
kind: .style,
nonTriggeringExamples: ExplicitReturnRuleExamples.nonTriggeringExamples,
triggeringExamples: ExplicitReturnRuleExamples.triggeringExamples,
corrections: ExplicitReturnRuleExamples.corrections
)
}
private extension ExplicitReturnRule {
final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
override var skippableDeclarations: [any DeclSyntaxProtocol.Type] { [ProtocolDeclSyntax.self] }
override func visitPost(_ node: AccessorDeclSyntax) {
if configuration.isKindIncluded(.getter),
node.accessorSpecifier.tokenKind == .keyword(.get),
let body = node.body {
collectViolation(in: body.statements)
}
}
override func visitPost(_ node: ClosureExprSyntax) {
if configuration.isKindIncluded(.closure) {
collectViolation(in: node.statements, isInsideClosure: true)
}
}
override func visitPost(_ node: FunctionDeclSyntax) {
if configuration.isKindIncluded(.function),
node.signature.allowsImplicitReturns,
let body = node.body {
collectViolation(in: body.statements)
}
}
override func visitPost(_ node: InitializerDeclSyntax) {
if configuration.isKindIncluded(.initializer),
node.optionalMark != nil,
let body = node.body {
collectViolation(in: body.statements)
}
}
override func visitPost(_ node: PatternBindingSyntax) {
if configuration.isKindIncluded(.getter),
case let .getter(itemList) = node.accessorBlock?.accessors {
collectViolation(in: itemList)
}
}
override func visitPost(_ node: SubscriptDeclSyntax) {
if configuration.isKindIncluded(.subscript),
case let .getter(itemList) = node.accessorBlock?.accessors {
collectViolation(in: itemList)
}
}
private func collectViolation(in itemList: CodeBlockItemListSyntax, isInsideClosure: Bool = false) {
guard let onlyItem = itemList.onlyElement?.item,
!onlyItem.is(ReturnStmtSyntax.self),
Syntax(onlyItem).isProtocol((any ExprSyntaxProtocol).self) else {
return
}
if isInsideClosure, Syntax(onlyItem).isFunctionCallExpr {
return
}
let position = onlyItem.positionAfterSkippingLeadingTrivia
violations.append(
at: position,
correction: .init(
start: position,
end: position,
replacement: "return "
)
)
}
}
}
private extension Syntax {
var isFunctionCallExpr: Bool {
if `is`(FunctionCallExprSyntax.self) {
return true
}
if let tryExpr = `as`(TryExprSyntax.self) {
return Syntax(tryExpr.expression).isFunctionCallExpr
}
if let awaitExpr = `as`(AwaitExprSyntax.self) {
return Syntax(awaitExpr.expression).isFunctionCallExpr
}
return false
}
}
private extension FunctionSignatureSyntax {
var allowsImplicitReturns: Bool {
guard let returnClause else { return false }
if let identifierType = returnClause.type.as(IdentifierTypeSyntax.self) {
return identifierType.name.text != "Void" && identifierType.name.text != "Never"
}
if let tupleType = returnClause.type.as(TupleTypeSyntax.self) {
return !tupleType.elements.isEmpty
}
return true
}
}