Fix multiline_call_arguments with enum-case patterns.#6444
Merged
SimplyDanny merged 5 commits intorealm:mainfrom Apr 11, 2026
Merged
Conversation
295f111 to
241eec6
Compare
Generated by 🚫 Danger |
241eec6 to
2800379
Compare
2800379 to
1cb7ca7
Compare
Contributor
Author
|
@SimplyDanny Hey-hey. One more PR to fix rule :) |
e553709 to
ff1b214
Compare
30e2640 to
b4c8cca
Compare
c4db9e6 to
2155214
Compare
93019ad to
6ab0d0c
Compare
992a540 to
986ca2c
Compare
SimplyDanny
requested changes
Apr 1, 2026
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Thanks for the update! Please consider my comments.
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRule.swift
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRuleExamples.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRuleExamples.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/MultilineCallArgumentsConfiguration.swift
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRuleExamples.swift
Outdated
Show resolved
Hide resolved
986ca2c to
c7e1b1b
Compare
Contributor
Author
@SimplyDanny Fixed your comments. Please re-review :) |
SimplyDanny
reviewed
Apr 7, 2026
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRule.swift
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/MultilineCallArgumentsRuleExamples.swift
Outdated
Show resolved
Hide resolved
22530d5 to
30289cf
Compare
30289cf to
23de616
Compare
SimplyDanny
approved these changes
Apr 10, 2026
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
I'm happy now. 😅 Thanks!
…RuleExamples.swift Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
23de616 to
6255ff2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes false positives in multiline_call_arguments when enum-case patterns (e.g. .caseOne(...)) are used in pattern-matching positions. SwiftSyntax represents such patterns as FunctionCallExprSyntax, so the rule previously treated them as real calls and produced violations.
Problem
The rule could incorrectly lint enum-case patterns in pattern-matching constructs, e.g.:
This is a pattern, not a function call, but it was previously linted as a call expression.
Fix
We now ignore FunctionCallExprSyntax nodes only when they are located inside a pattern subtree (pattern-part only), by walking up the parent chain and checking containment within pattern containers: