Skip to content

Fix multiline_call_arguments with enum-case patterns.#6444

Merged
SimplyDanny merged 5 commits intorealm:mainfrom
GandaLF2006:gandalf2006/multiline_call_arguments-improve
Apr 11, 2026
Merged

Fix multiline_call_arguments with enum-case patterns.#6444
SimplyDanny merged 5 commits intorealm:mainfrom
GandaLF2006:gandalf2006/multiline_call_arguments-improve

Conversation

@GandaLF2006
Copy link
Copy Markdown
Contributor

Summary

This PR fixes false positives in multiline_call_arguments when enum-case patterns (e.g. .caseOne(...)) are used in pattern-matching positions. SwiftSyntax represents such patterns as FunctionCallExprSyntax, so the rule previously treated them as real calls and produced violations.

Problem

The rule could incorrectly lint enum-case patterns in pattern-matching constructs, e.g.:

if case .caseOne(1, 2, 3, 4) = value {
    // ...
}

This is a pattern, not a function call, but it was previously linted as a call expression.

Fix

We now ignore FunctionCallExprSyntax nodes only when they are located inside a pattern subtree (pattern-part only), by walking up the parent chain and checking containment within pattern containers:

  • MatchingPatternConditionSyntax (e.g. if/guard/while case ...)
  • SwitchCaseItemSyntax (e.g., case .foo(...))
  • ForStmtSyntax (e.g., for case let .foo(...) in ...)
  • CatchClauseSyntax (e.g. catch EnumCase.foo(...) / catch let EnumCase.foo(...))

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch from 295f111 to 241eec6 Compare January 17, 2026 16:39
@SwiftLintBot
Copy link
Copy Markdown

SwiftLintBot commented Jan 17, 2026

4244 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/NowPlayingViewController.swift:212:95: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:232:113: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:258:108: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:266:109: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:307:84: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:328:84: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/VideosViewController.swift:716:69: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:47:152: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:52:136: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:84:64: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:153:84: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:223:84: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:267:84: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:303:84: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:179:37: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:183:66: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/FileHelpers.swift:17:84: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoCommonView.swift:157:81: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/ClockLayer.swift:80:39: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/BatteryIconLayer.swift:76:42: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:94:69: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:97:70: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:133:69: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:136:70: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:65:47: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:93:47: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:253:40: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:352:40: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:638:23: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:643:73: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:646:72: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in Alamofire: /Tests/TestHelpers.swift:467:22: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/NewPermissionViewTests.swift:849:32: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/StateRestorationPromptTests.swift:144:13: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/Common/XCUIApplicationExtension.swift:348:17: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/SSLErrorTests.swift:154:65: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/SSLErrorTests.swift:161:65: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:122:35: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:137:35: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:222:35: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:353:38: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:399:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:466:112: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:508:112: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:62:44: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:143:41: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:162:41: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:181:41: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:203:41: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:268:41: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionDataManagingTests.swift:205:20: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionDataManagingTests.swift:238:20: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionDataManagingTests.swift:254:40: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionDataManagingTests.swift:284:20: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionDataManagingTests.swift:316:20: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionAgentManagerTests.swift:204:96: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Preferences/StartupPreferencesTests.swift:114:78: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Preferences/StartupPreferencesTests.swift:121:74: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Preferences/StartupPreferencesTests.swift:129:74: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/RemoteMessaging/ActiveRemoteMessageModelTests.swift:36:74: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:61:54: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:96:54: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:126:54: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+WithoutPinnedTabsManager.swift:328:93: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+WithoutPinnedTabsManager.swift:336:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+PinnedTabs.swift:184:93: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+PinnedTabs.swift:193:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests.swift:345:93: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests.swift:353:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/SecureVault/PasswordManagementItemListModelTests.swift:299:82: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionCenterViewModelTests.swift:355:117: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/NavigationBar/ViewModel/PrivacyIconViewModelTests.swift:46:82: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/NavigationBar/ViewModel/PrivacyIconViewModelTests.swift:61:45: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:170:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:213:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:247:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:277:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:318:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:733:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:752:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:771:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:781:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:800:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:820:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:840:31: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/FirefoxBookmarksReaderTests.swift:44:13: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/FirefoxBookmarksReaderTests.swift:47:13: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/FirefoxBookmarksReaderTests.swift:50:13: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/FileImportViewLocalizationTests.swift:79:86: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Subscription/PreferencesSubscriptionSettingsModelTests.swift:155:12: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Subscription/PreferencesSubscriptionSettingsModelTests.swift:191:12: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Subscription/PreferencesSubscriptionSettingsModelTests.swift:227:12: Warning: In multi-line calls, a newline is required after each comma (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:355:62: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:371:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:386:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:401:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:413:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:425:62: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:442:89: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/AIChat/AIChatCoordinatorTests.swift:501:93: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/AIChat/AIChatOmnibarControllerTests.swift:401:50: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:192:76: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:437:39: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:471:39: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:515:39: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:533:39: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:1727:65: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/Extensions/FileManagerExtensionTests.swift:123:51: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/Extensions/FileManagerExtensionTests.swift:141:51: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1046:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1075:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1080:44: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1114:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1150:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1155:44: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1180:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1197:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1202:44: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1222:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1254:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1262:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1267:44: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1292:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1301:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1305:68: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1330:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1337:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1344:43: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1346:68: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1389:55: Warning: In multi-line calls, each argument must start on its own line (multiline_call_arguments)
⚠️ Danger found 4244 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 131.
3949 Messages
📖 Building this branch resulted in a binary size of 27495.63 KiB vs 27477.29 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.82 s vs 0.78 s on main (5% slower).
📖 Linting Alamofire with this PR took 1.04 s vs 1.04 s on main (0% slower).
📖 Linting Brave with this PR took 7.19 s vs 7.22 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 27.74 s vs 27.77 s on main (0% faster).
📖 Linting Firefox with this PR took 12.04 s vs 12.1 s on main (0% faster).
📖 Linting Kickstarter with this PR took 8.4 s vs 8.33 s on main (0% slower).
📖 Linting Moya with this PR took 0.46 s vs 0.47 s on main (2% faster).
📖 Linting NetNewsWire with this PR took 2.61 s vs 2.63 s on main (0% faster).
📖 Linting Nimble with this PR took 0.68 s vs 0.7 s on main (2% faster).
📖 Linting PocketCasts with this PR took 7.79 s vs 7.9 s on main (1% faster).
📖 Linting Quick with this PR took 0.48 s vs 0.46 s on main (4% slower).
📖 Linting Realm with this PR took 2.97 s vs 2.91 s on main (2% slower).
📖 Linting Sourcery with this PR took 1.89 s vs 1.87 s on main (1% slower).
📖 Linting Swift with this PR took 4.64 s vs 4.65 s on main (0% faster).
📖 Linting SwiftLintPerformanceTests with this PR took 0.33 s vs 0.36 s on main (8% faster).
📖 Linting VLC with this PR took 1.22 s vs 1.25 s on main (2% faster).
📖 Linting Wire with this PR took 18.75 s vs 18.77 s on main (0% faster).
📖 Linting WordPress with this PR took 12.69 s vs 12.68 s on main (0% slower).
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:45:17: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:50:17: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:83:32: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:152:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:222:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:266:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:302:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Aerial.swift:179:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Aerial.swift:179:24: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Downloads/FileHelpers.swift:16:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/ClockLayer.swift:78:40: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/BatteryIconLayer.swift:76:28: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:65:34: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:93:34: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:253:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:352:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView.swift:637:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView.swift:641:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView.swift:644:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in Alamofire: /Tests/TestHelpers.swift:467:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/NewPermissionViewTests.swift:848:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:122:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:137:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:222:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:353:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:399:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:466:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AIChatTests.swift:508:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/SSLErrorTests.swift:154:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/SSLErrorTests.swift:161:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:62:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:143:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:162:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:181:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:203:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UITests/AddressBarSpoofingUITests.swift:268:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionDataManagingTests.swift:251:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/DataBrokerProtection-macOS/Tests/DataBrokerProtection-macOSTests/DataBrokerProtectionAgentManagerTests.swift:200:28: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Preferences/StartupPreferencesTests.swift:114:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Preferences/StartupPreferencesTests.swift:121:17: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Preferences/StartupPreferencesTests.swift:129:17: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/RemoteMessaging/ActiveRemoteMessageModelTests.swift:33:19: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:61:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:96:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:126:21: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+PinnedTabs.swift:184:38: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+PinnedTabs.swift:193:34: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+WithoutPinnedTabsManager.swift:328:38: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests+WithoutPinnedTabsManager.swift:336:34: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests.swift:345:38: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/TabBar/ViewModel/TabCollectionViewModelTests.swift:353:34: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/SecureVault/PasswordManagementItemListModelTests.swift:299:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionCenterViewModelTests.swift:355:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/NavigationBar/ViewModel/PrivacyIconViewModelTests.swift:46:17: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/NavigationBar/ViewModel/PrivacyIconViewModelTests.swift:61:17: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:170:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:213:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:247:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:277:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:318:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:733:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:752:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:771:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:781:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:800:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:820:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Permissions/PermissionModelTests.swift:840:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/FileImportViewLocalizationTests.swift:79:25: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:355:18: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:370:18: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:385:18: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:400:18: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:412:18: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:425:18: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/QuitSurvey/QuitSurveyViewModelTests.swift:441:18: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/AIChat/AIChatCoordinatorTests.swift:501:38: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/AIChat/AIChatOmnibarControllerTests.swift:401:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:192:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:437:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:471:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:515:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:533:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataImport/LegacyDataImportViewModelTests.swift:1727:17: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/Extensions/FileManagerExtensionTests.swift:123:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/Extensions/FileManagerExtensionTests.swift:141:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1046:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1075:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1080:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1114:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1150:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1155:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1180:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1197:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1202:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1222:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1254:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1262:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1267:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1292:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1301:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1305:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1330:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1337:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1344:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1346:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1389:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Fire/FireDialogViewModelTests.swift:1399:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:462:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:466:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:469:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:473:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:476:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:479:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:483:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:486:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:490:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:493:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:1006:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:1008:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:1010:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:1013:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:1016:27: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift:1018:31: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/NewTabPage/NewTabPageOmnibarModelsProviderTests.swift:53:13: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/NetworkProtection/WinBackOfferPromptPresenterTests.swift:39:15: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/StateRestoration/TabRestorationDataCodingTests.swift:233:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/StateRestoration/TabRestorationDataCodingTests.swift:235:9: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
📖 This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Autoconsent/AutoconsentMessageProtocolTests.swift:109:23: Warning: Call should have each parameter on a separate line (multiline_call_arguments)
⚠️ Danger found 3949 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 147.

Generated by 🚫 Danger

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch from 241eec6 to 2800379 Compare January 17, 2026 16:40
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch from 2800379 to 1cb7ca7 Compare January 24, 2026 21:58
@GandaLF2006
Copy link
Copy Markdown
Contributor Author

@SimplyDanny Hey-hey. One more PR to fix rule :)

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch 3 times, most recently from e553709 to ff1b214 Compare February 22, 2026 17:16
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch 2 times, most recently from 30e2640 to b4c8cca Compare March 3, 2026 14:47
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch 2 times, most recently from c4db9e6 to 2155214 Compare March 8, 2026 14:23
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch 2 times, most recently from 93019ad to 6ab0d0c Compare March 20, 2026 21:26
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch 2 times, most recently from 992a540 to 986ca2c Compare March 30, 2026 20:29
Copy link
Copy Markdown
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Please consider my comments.

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch from 986ca2c to c7e1b1b Compare April 2, 2026 11:56
@GandaLF2006 GandaLF2006 requested a review from SimplyDanny April 2, 2026 11:58
@GandaLF2006
Copy link
Copy Markdown
Contributor Author

Thanks for the update! Please consider my comments.

@SimplyDanny Fixed your comments. Please re-review :)

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch from 22530d5 to 30289cf Compare April 7, 2026 21:59
@GandaLF2006 GandaLF2006 requested a review from SimplyDanny April 8, 2026 07:38
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch from 30289cf to 23de616 Compare April 10, 2026 19:44
Copy link
Copy Markdown
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy now. 😅 Thanks!

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/multiline_call_arguments-improve branch from 23de616 to 6255ff2 Compare April 10, 2026 20:03
@SimplyDanny SimplyDanny merged commit a7878fc into realm:main Apr 11, 2026
25 checks passed
@GandaLF2006 GandaLF2006 deleted the gandalf2006/multiline_call_arguments-improve branch April 11, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants