Skip to content

Improve pattern_matching_keywords SwiftSyntax rule#6534

Open
GandaLF2006 wants to merge 3 commits intorealm:mainfrom
GandaLF2006:gandalf2006/pattern_matching_keywords-improve
Open

Improve pattern_matching_keywords SwiftSyntax rule#6534
GandaLF2006 wants to merge 3 commits intorealm:mainfrom
GandaLF2006:gandalf2006/pattern_matching_keywords-improve

Conversation

@GandaLF2006
Copy link
Copy Markdown
Contributor

Summary

This PR improves the existing opt-in SwiftLint rule pattern_matching_keywords.

Compared to the original implementation, the rule now covers more pattern-matching contexts and handles nested tuple/enum associated value patterns more reliably.

What changed

The original implementation only analyzed switch case items and relied on a narrower syntax-based approach.

This update expands the rule to also check:

  • if case
  • guard case
  • while case
  • for case
  • catch

It also improves handling of:

  • nested tuple patterns
  • nested enum associated value patterns
  • labeled associated values
  • multi-pattern case clauses

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/pattern_matching_keywords-improve branch from a42f3d1 to 992cd9e Compare March 9, 2026 23:10
@SwiftLintBot
Copy link
Copy Markdown

SwiftLintBot commented Mar 9, 2026

2383 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:196:51: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:196:60: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:198:52: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:198:62: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:200:53: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:200:63: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:234:47: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:234:56: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:236:48: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:236:58: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:238:49: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:238:59: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/BrowserMenuTests/BrowserMenuTests.swift:328:21: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Tests/BrowserMenuTests/BrowserMenuTests.swift:328:33: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:129:26: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:129:49: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:212:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:212:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:212:59: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:226:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:226:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/FeedItemView.swift:346:21: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveNews/FeedItemView.swift:346:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BrowserMenu/BrowserMenu.swift:111:28: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BrowserMenu/BrowserMenu.swift:111:40: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:833:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:833:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:835:22: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:835:36: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:847:29: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:847:43: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:858:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:858:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:867:34: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:867:48: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:869:19: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:869:33: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:871:31: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:871:45: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:878:35: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:878:49: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:59:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:59:50: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:116:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:116:51: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:234:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:234:50: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:412:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:412:45: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:412:66: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:427:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:427:44: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:427:65: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Extensions/WalletAmountFormatter.swift:77:21: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Extensions/WalletAmountFormatter.swift:77:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NavigationRouter.swift:82:15: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NavigationRouter.swift:82:24: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+AIChat.swift:22:35: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+AIChat.swift:22:45: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ToolbarDelegate.swift:394:26: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ToolbarDelegate.swift:394:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:157:19: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:157:33: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:162:21: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:162:35: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController.swift:2800:18: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController.swift:2800:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:311:17: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:311:28: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:368:17: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:368:28: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:368:39: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:397:20: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:397:31: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:708:28: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:708:53: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:839:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:839:44: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:839:73: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:951:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:952:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:957:25: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:958:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/AddEditBookmarkTableViewController.swift:52:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/AddEditBookmarkTableViewController.swift:52:34: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/UserScripts/ScriptFactory.swift:133:27: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/UserScripts/ScriptFactory.swift:133:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveRewards/Ads/AdSwipeButton.swift:41:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveRewards/Ads/AdSwipeButton.swift:41:26: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/DeviceCheck/DeviceCheck.swift:333:26: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/DeviceCheck/DeviceCheck.swift:333:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:61:22: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:61:43: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:83:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:83:36: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/CustomFilterListStorage.swift:29:24: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/CustomFilterListStorage.swift:29:34: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveTalk/BraveTalkJitsiCoordinator.swift:47:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/BraveTalk/BraveTalkJitsiCoordinator.swift:47:46: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:70:18: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:70:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:73:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:73:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:74:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:74:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:130:19: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:130:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/Shared/ActionMessageView.swift:61:29: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/Shared/ActionMessageView.swift:61:53: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/ContentBlocking.swift:106:48: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/ContentBlocking.swift:106:62: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/ContentBlocking.swift:140:57: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/ContentBlocking.swift:140:73: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2429:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2429:60: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2435:42: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2435:61: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2446:48: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2446:62: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2454:57: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2454:77: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2485:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2485:63: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2485:87: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:3524:44: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:3524:73: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:3536:61: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:3536:81: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:3551:34: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:3551:48: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:3561:51: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples
⚠️ Danger found 2383 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 131.
2185 Messages
📖 Building this branch resulted in a binary size of 27494.87 KiB vs 27495.63 KiB when built on main (-1% smaller).
📖 Linting Aerial with this PR took 0.8 s vs 0.8 s on main (0% slower).
📖 Linting Alamofire with this PR took 1.06 s vs 1.01 s on main (4% slower).
📖 Linting Brave with this PR took 7.24 s vs 7.24 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 27.97 s vs 27.86 s on main (0% slower).
📖 Linting Firefox with this PR took 12.14 s vs 12.16 s on main (0% faster).
📖 Linting Kickstarter with this PR took 8.37 s vs 8.38 s on main (0% faster).
📖 Linting Moya with this PR took 0.47 s vs 0.44 s on main (6% slower).
📖 Linting NetNewsWire with this PR took 2.61 s vs 2.62 s on main (0% faster).
📖 Linting Nimble with this PR took 0.7 s vs 0.68 s on main (2% slower).
📖 Linting PocketCasts with this PR took 7.71 s vs 7.74 s on main (0% faster).
📖 Linting Quick with this PR took 0.45 s vs 0.45 s on main (0% slower).
📖 Linting Realm with this PR took 2.98 s vs 2.99 s on main (0% faster).
📖 Linting Sourcery with this PR took 1.91 s vs 1.9 s on main (0% slower).
📖 Linting Swift with this PR took 4.7 s vs 4.66 s on main (0% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 0.33 s vs 0.31 s on main (6% slower).
📖 Linting VLC with this PR took 1.25 s vs 1.21 s on main (3% slower).
📖 Linting Wire with this PR took 18.86 s vs 18.77 s on main (0% slower).
📖 Linting WordPress with this PR took 12.73 s vs 12.72 s on main (0% slower).
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:196:51: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:196:60: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:198:52: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:198:62: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:200:53: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:200:63: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:234:47: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:234:56: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:236:48: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:236:58: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:238:49: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:238:59: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Tests/BrowserMenuTests/BrowserMenuTests.swift:328:21: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Tests/BrowserMenuTests/BrowserMenuTests.swift:328:33: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:212:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:212:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:212:59: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:226:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveNews/Composer/FeedCardGenerator.swift:226:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveNews/FeedItemView.swift:346:21: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveNews/FeedItemView.swift:346:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:833:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:833:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:835:22: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:835:36: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:847:29: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:847:43: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:858:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:858:37: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:867:34: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:867:48: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:869:19: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:869:33: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:871:31: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:871:45: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:878:35: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift:878:49: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:116:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:116:51: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:234:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/CryptoView.swift:234:50: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:412:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:412:45: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:412:66: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:427:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:427:44: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/WalletActions/DepositTokenView.swift:427:65: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NavigationRouter.swift:82:15: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NavigationRouter.swift:82:24: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+AIChat.swift:22:35: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+AIChat.swift:22:45: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ToolbarDelegate.swift:394:26: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ToolbarDelegate.swift:394:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:157:19: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:157:33: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:162:21: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/ToolbarVisibilityViewModel.swift:162:35: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController.swift:2800:18: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController.swift:2800:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:311:17: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:311:28: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:368:17: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:368:28: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:368:39: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:397:20: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/Sections/BraveNewsSectionProvider.swift:397:31: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:839:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:839:44: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:839:73: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:951:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/NewTabPage/NewTabPageViewController.swift:952:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/AddEditBookmarkTableViewController.swift:52:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/AddEditBookmarkTableViewController.swift:52:34: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/UserScripts/ScriptFactory.swift:133:27: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/Browser/UserScripts/ScriptFactory.swift:133:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveRewards/Ads/AdSwipeButton.swift:41:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/Frontend/BraveRewards/Ads/AdSwipeButton.swift:41:26: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/DeviceCheck/DeviceCheck.swift:333:26: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/DeviceCheck/DeviceCheck.swift:333:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:61:22: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:61:43: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:83:23: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/ResourceDownloader.swift:83:36: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/CustomFilterListStorage.swift:29:24: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/CustomFilterListStorage.swift:29:34: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveTalk/BraveTalkJitsiCoordinator.swift:47:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveTalk/BraveTalkJitsiCoordinator.swift:47:46: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:70:18: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:70:38: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:73:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:73:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:74:16: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:74:30: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:130:19: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/AIChat/Components/Feedback/AIChatFeedbackToastView.swift:130:32: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:166:40: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:166:59: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:166:76: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:167:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:167:58: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:167:78: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:168:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:178:40: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:178:59: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:178:76: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:179:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:179:60: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:179:79: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:180:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:180:60: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:180:80: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:181:41: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:194:43: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
📖 This PR fixed a violation in DuckDuckGo: /macOS/LocalPackages/AppUpdater/Sources/AppUpdaterShared/UpdateFlowPixels.swift:194:62: Warning: Combine multiple pattern matching bindings by moving keywords out of tuples (pattern_matching_keywords)
⚠️ Danger found 2185 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 133.

Generated by 🚫 Danger

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/pattern_matching_keywords-improve branch 2 times, most recently from 1a809bf to b14f17b Compare March 9, 2026 23:27
@GandaLF2006
Copy link
Copy Markdown
Contributor Author

@SimplyDanny It would be great if you can review it

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/pattern_matching_keywords-improve branch 2 times, most recently from ec4ab2e to 64d1527 Compare March 20, 2026 21:26
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/pattern_matching_keywords-improve branch 3 times, most recently from 090bf28 to 1dc7fed Compare April 1, 2026 19:34
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/pattern_matching_keywords-improve branch 2 times, most recently from 92ac628 to 4941317 Compare April 10, 2026 20:03
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/pattern_matching_keywords-improve branch from 4941317 to 610b04a Compare April 11, 2026 07:13
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/pattern_matching_keywords-improve branch from 610b04a to d907be7 Compare April 12, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants