Fix false positives in vertical_parameter_alignment_on_call with Unicode#6535
Open
theamodhshetty wants to merge 1 commit intorealm:mainfrom
Open
Conversation
Generated by 🚫 Danger |
SimplyDanny
reviewed
Apr 10, 2026
| """), | ||
| Example(""" | ||
| func test() { | ||
| СreateAdUpdateShopHelper.updateShopModels(categoryModels: &categoryModels, |
Collaborator
There was a problem hiding this comment.
If we do the following, the test case would fail (with adapted parameter indentation):
Suggested change
| СreateAdUpdateShopHelper.updateShopModels(categoryModels: &categoryModels, | |
| СreateAd😵💫UpdateShopHelper.updateShopModels(categoryModels: &categoryModels, |
There might exist code you can reuse. I remember that we have done something similar in other rules already, but can't remember where exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6467.
Testing