-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Adds Variable Shadowing Rule #6568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SimplyDanny
merged 18 commits into
realm:main
from
nadeemnali:feature/variable-shadowing-rule
Apr 13, 2026
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f0be193
Adds Variable Shadowing Rule
nadeemnali a38e952
Updates failing test cases
nadeemnali a98d1cb
Update Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.…
nadeemnali a8656e1
Update Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.…
nadeemnali 8ed956a
Update Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.…
nadeemnali 3ab398b
Update Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.…
nadeemnali f8d55d4
Updated Examples
nadeemnali 9c1a196
Refactored the conditions
nadeemnali 5cd9dd6
Updated Triggering examples with additional use cases
nadeemnali 6d525f7
Apply suggestion
nadeemnali 9d29fbe
Fixed failing registration issue
nadeemnali 003b2c5
Added Configuration for the function shadowing
nadeemnali 373aa38
Updated generated tests
nadeemnali 650ba2c
Updated additional examples, change rule to opt In
nadeemnali 4a0ca31
Updated ShadowingAnyScope to use base function
nadeemnali d28ac00
Add idiomatic optional binding detection
nadeemnali 6519112
Update check for shadowing methods to be unified
nadeemnali ae84a03
Sort alphabetically
SimplyDanny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.