From 39a5e8851b9ae3251b5f09177ed7fc9c35bead4c Mon Sep 17 00:00:00 2001
From: Guilherme Volney Mota Amaral <gvma@ic.ufal.br>
Date: Fri, 26 Jun 2020 13:07:00 -0300
Subject: [PATCH 1/2] Improving test quality

---
 .../io/realm/.RealmRecyclerAdapterTests.java.swp | Bin 0 -> 1024 bytes
 .../java/io/realm/RealmRecyclerAdapterTests.java |   8 ++------
 2 files changed, 2 insertions(+), 6 deletions(-)
 create mode 100644 tests/src/androidTest/java/io/realm/.RealmRecyclerAdapterTests.java.swp

diff --git a/tests/src/androidTest/java/io/realm/.RealmRecyclerAdapterTests.java.swp b/tests/src/androidTest/java/io/realm/.RealmRecyclerAdapterTests.java.swp
new file mode 100644
index 0000000000000000000000000000000000000000..8d5860b386b44627a4f6b18e156ae0342eeda035
GIT binary patch
literal 1024
zcmeH@O$x$54263XFVIGG<x=njRrkg;*p~Sz$+X~YJgOZ=N|Aa2X;$IA??LkJTZhhX
zcEzFCXR~?Tvh2|}re?7`)0ftX%MH=6L?jJrZy6>UPM&(pE+|}B!`ZSi3Z3|tY1D+#
z*c@FYzNvDounQ~-VMG;F2tHQKLW=`J<5LLA7%iEeWLS<V88Iy)_xr%rSsVE82Cm=l
Fy#dc3LG}Ou

literal 0
HcmV?d00001

diff --git a/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java b/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java
index f197948..6b293cf 100644
--- a/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java
+++ b/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java
@@ -68,16 +68,12 @@ public void tearDown() {
         realm.close();
     }
 
-    @Test
+    @Test(expected = IllegalStateException.class)
     @UiThreadTest
     public void constructor_testRecyclerAdapterUnmanagedParameterExceptions() {
         RealmResults<AllJavaTypes> resultList = realm.where(AllJavaTypes.class).findAll();
         RealmList<AllJavaTypes> unmanagedRealmList = new RealmList<>(resultList.toArray(new AllJavaTypes[0]));
-        try {
-            new RecyclerViewTestAdapter(context, unmanagedRealmList, true);
-            fail("Should throw exception if list is un-managed");
-        } catch (IllegalStateException ignore) {
-        }
+        new RecyclerViewTestAdapter(context, unmanagedRealmList, true);
     }
 
     @Test

From d9bb67ae553c5dec62446540c0d8a762023877a5 Mon Sep 17 00:00:00 2001
From: Guilherme Volney Mota Amaral <gvma@ic.ufal.br>
Date: Fri, 26 Jun 2020 13:15:17 -0300
Subject: [PATCH 2/2] Updating test file

---
 tests/.project                                  | 17 +++++++++++++++++
 .../.settings/org.eclipse.buildship.core.prefs  | 13 +++++++++++++
 .../io/realm/RealmRecyclerAdapterTests.java     | 15 ++++++---------
 3 files changed, 36 insertions(+), 9 deletions(-)
 create mode 100644 tests/.project
 create mode 100644 tests/.settings/org.eclipse.buildship.core.prefs

diff --git a/tests/.project b/tests/.project
new file mode 100644
index 0000000..dcac2b9
--- /dev/null
+++ b/tests/.project
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>tests</name>
+	<comment>Project tests created by Buildship.</comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
+	</natures>
+</projectDescription>
diff --git a/tests/.settings/org.eclipse.buildship.core.prefs b/tests/.settings/org.eclipse.buildship.core.prefs
new file mode 100644
index 0000000..306a8c8
--- /dev/null
+++ b/tests/.settings/org.eclipse.buildship.core.prefs
@@ -0,0 +1,13 @@
+arguments=
+auto.sync=false
+build.scans.enabled=false
+connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(6.3))
+connection.project.dir=
+eclipse.preferences.version=1
+gradle.user.home=
+java.home=/usr/lib/jvm/java-11-openjdk-amd64
+jvm.arguments=
+offline.mode=false
+override.workspace.settings=true
+show.console.view=true
+show.executions.view=true
diff --git a/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java b/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java
index 6b293cf..eb258d8 100644
--- a/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java
+++ b/tests/src/androidTest/java/io/realm/RealmRecyclerAdapterTests.java
@@ -131,17 +131,14 @@ public void updateData_replaceInvalidData() {
         realmAdapter.updateData(resultList);
     }
 
-    @Test
+    @Test (expected = IllegalArgumentException.class)
     @UiThreadTest
     public void updateData_realmUnsupportedCollectionInAdapter() {
-        try {
-            RecyclerViewTestAdapter realmAdapter = new RecyclerViewTestAdapter(context, null, AUTOMATIC_UPDATE);
-            RealmResults<AllJavaTypes> results =
-                    realm.where(AllJavaTypes.class).sort(AllJavaTypes.FIELD_STRING).findAll();
-            realmAdapter.updateData(results.createSnapshot());
-            fail("Should throw exception if there is unsupported collection");
-        } catch (IllegalArgumentException ignore) {
-        }
+        RecyclerViewTestAdapter realmAdapter = new RecyclerViewTestAdapter(context, null, AUTOMATIC_UPDATE);
+        RealmResults<AllJavaTypes> results =
+                realm.where(AllJavaTypes.class).sort(AllJavaTypes.FIELD_STRING).findAll();
+        realmAdapter.updateData(results.createSnapshot());
+
     }
 
     @Test