Background context:
- SideBar currently sizes itself incorrectly. While it has a min and max width, it is not able to size itself to the longest menu item, because some menu items will be hidden inside a menu group. Further, when used in real products, the side bar's container will often want to size itself to the minimum size its content. This leads to many menu items being truncated when they shouldn't be.
- SideBar components were recently refactored. Its item components used an
isActive prop to indicate whether the item is the current page or not.
- TopBar components were also recently refactored. Its item components used the
aria-current attribute directly, instead of an abstracted isActive prop.
Specification or tasks to perform:
- Update SideBar's item components to also use
aria-current directly, instead of isActive
- Update SideBar to accept a
width prop that specifies the exact, fixed width of the side bar.
Background context:
isActiveprop to indicate whether the item is the current page or not.aria-currentattribute directly, instead of an abstractedisActiveprop.Specification or tasks to perform:
aria-currentdirectly, instead ofisActivewidthprop that specifies the exact, fixed width of the side bar.