Skip to content

feat: add code connect for FolderTabs, PrimaryTabs, SecondaryTabs, and Tooltip#785

Merged
kurtdoherty merged 1 commit into
mainfrom
feat-add-figma-code-connect-part-5
Sep 15, 2025
Merged

feat: add code connect for FolderTabs, PrimaryTabs, SecondaryTabs, and Tooltip#785
kurtdoherty merged 1 commit into
mainfrom
feat-add-figma-code-connect-part-5

Conversation

@kurtdoherty
Copy link
Copy Markdown
Contributor

@kurtdoherty kurtdoherty commented Sep 15, 2025

Context

This PR

  • Connects folder tabs, primary tabs, secondary tabs and tooltips.
  • Excludes Figma code connect files to our Vitest code coverage config.

@rpt-uk-github
Copy link
Copy Markdown

rpt-uk-github commented Sep 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty changed the title feat: add code connect for FolderTabs, PrimaryTabs, `SecondaryTab… feat: add code connect for FolderTabs, PrimaryTabs, SecondaryTabs, and Tooltip Sep 15, 2025
@kurtdoherty kurtdoherty force-pushed the feat-add-figma-code-connect-part-5 branch from a15d21d to b1e42ed Compare September 15, 2025 21:01
@kurtdoherty kurtdoherty marked this pull request as ready for review September 15, 2025 21:02
Comment thread vite.config.ts
@@ -122,6 +122,8 @@ export default defineConfig({
'**/__story__/**',
// - barrel files
'**/index.ts',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we forgot to add this in #781 so our code coverage has now dropped below the threshold 🤦

@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 86d31341 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (86d3134) Report Missing Report Missing Report Missing
Head commit (b1e42ed) 9281 8587 92.52%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#785) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants