refactor: complete monorepo with extension in packages/#372
Merged
Conversation
af00b46 to
edefb75
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 93.45% 91.13% -2.32%
==========================================
Files 85 85
Lines 4184 4184
Branches 918 918
==========================================
- Hits 3910 3813 -97
- Misses 246 329 +83
- Partials 28 42 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Extract PHPUnit core (parser, runner, test output, tree-sitter) into `packages/phpunit` as `@vscode-phpunit/phpunit` - Move extension into `packages/extension`, consuming phpunit as dependency - esbuild bundles extension into single file; tsup builds phpunit (ESM+CJS) - tree-sitter WASM files copied from node_modules during build - Migrate all unit tests to Vitest across both packages - Update CI workflows (tests, e2e, publish) for monorepo structure - Add per-package biome configs and lefthook integration - Bump extension version to 3.9.14
2449292 to
a4b16f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/phpunit/workspace packagepackages/extension/workspace packagepackage.jsonnow serves only as workspace orchestratortsconfig.json,vitest.config.ts, andbiome.jsontsconfig.json,vitest.config.ts,biome.json,qodana.yaml,vsc-extension-quickstart.md)tests.yml,e2e.yml,publish.yml) for new paths.vscode/launch.jsonandtasks.jsonfor new structureTest plan
pnpm installsucceedspnpm -r run typecheckpasses for both packagespnpm -r run lintpasses for both packagespnpm -r run test— phpunit (561 tests), extension (344 tests) all passnode packages/extension/esbuild.mjsbuilds successfullyvsce package --no-dependenciesproduces valid VSIX