fix(github): address discussions proxy review

Author: Abhash-Chakraborty

api/github-discussions.js

@@ -125,15 +125,11 @@ async function fetchGitHubDiscussions(token, limit) {
   };
 }
 
-export default async function handler(req, res) {
+async function handler(req, res) {
   const token = getToken();
 
-  res.setHeader(
-    "Cache-Control",
-    "public, s-maxage=300, stale-while-revalidate=600",
-  );
-
   if (!token) {
+    res.setHeader("Cache-Control", "no-store");
     res.status(503).json({
       available: false,
       message: UNAVAILABLE_MESSAGE,
@@ -147,8 +143,13 @@ export default async function handler(req, res) {
   try {
     const limit = parseLimit(req.query.limit);
     const data = await fetchGitHubDiscussions(token, limit);
+    res.setHeader(
+      "Cache-Control",
+      "public, s-maxage=300, stale-while-revalidate=600",
+    );
     res.status(200).json(data);
   } catch (error) {
+    res.setHeader("Cache-Control", "no-store");
     res.status(502).json({
       available: false,
       message:
@@ -161,3 +162,5 @@ export default async function handler(req, res) {
     });
   }
 }
+
+module.exports = handler;

src/services/githubService.ts

@@ -252,10 +252,7 @@ class GitHubService {
     }
 
     try {
-      const [, repositories] = await Promise.all([
-        this.fetchOrganizationInfo(signal),
-        this.fetchAllRepositories(signal),
-      ]);
+      const repositories = await this.fetchAllRepositories(signal);
 
       // Filter out archived repositories for active stats
       const activeRepos = repositories.filter((repo) => !repo.archived);
@@ -341,10 +338,25 @@ class GitHubService {
       },
     );
 
-    const payload = (await response.json()) as GitHubDiscussionsResponse;
+    const contentType = response.headers.get("Content-Type") || "";
+    const isJsonResponse = contentType.includes("application/json");
+    const fallbackMessage = `Failed to fetch GitHub discussions: ${response.status} ${response.statusText}`;
+    let payload: GitHubDiscussionsResponse | null = null;
+
+    if (isJsonResponse) {
+      try {
+        payload = (await response.json()) as GitHubDiscussionsResponse;
+      } catch {
+        throw new Error(`${fallbackMessage} (invalid JSON response)`);
+      }
+    }
 
     if (!response.ok) {
-      throw new Error(payload.message || "Failed to fetch GitHub discussions.");
+      throw new Error(payload?.message || fallbackMessage);
+    }
+
+    if (!payload) {
+      throw new Error(`${fallbackMessage} (non-JSON response)`);
     }
 
     return payload;

wiki/Documentation.md

@@ -591,7 +591,7 @@ For this site, GitHub Discussions are now fetched dynamically through a server-s
 
 Go to GitHub Settings → Developer settings → Personal access tokens → Tokens (classic)
 Generate new token
-Select scopes: public_repo, read:org
+Select scopes: public_repo, read:org, read:discussion
 Copy the token (you won't see it again!)
 
 #### Storing the Token: