Skip to content

Commit cda8ccf

Browse files
authored
fix: address code review — move inline styles to CSS, fix visualization spelling
Agent-Logs-Url: https://github.com/recodehive/recode-website/sessions/30250193-58e1-450c-a5ab-15dd9e0d11d5
1 parent 79e584b commit cda8ccf

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

src/data/coursesData.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ export const coursesData: Course[] = [
263263
category: "data-science",
264264
difficulty: "Beginner",
265265
duration: "6 hrs",
266-
tags: ["Data Visualisation", "Matplotlib", "Seaborn", "Plotly", "Python"],
266+
tags: ["Data Visualization", "Matplotlib", "Seaborn", "Plotly", "Python"],
267267
freePlatforms: [
268268
{
269269
name: "Kaggle",

src/pages/courses/courses.css

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,16 @@
373373
box-shadow: var(--courses-shadow-lg);
374374
}
375375

376+
/* Allow <a> elements styled as the primary button to look/behave correctly */
377+
a.courses-button-link {
378+
display: inline-flex;
379+
text-decoration: none;
380+
}
381+
382+
a.courses-button-link:hover {
383+
text-decoration: none;
384+
}
385+
376386
.courses-button-primary:hover {
377387
background: linear-gradient(135deg, #2563eb 0%, #4f46e5 100%);
378388
transform: translateY(-3px);

src/pages/courses/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -503,8 +503,7 @@ function CoursesContent() {
503503
>
504504
<a
505505
href="/courses/explore"
506-
className="courses-button-primary group courses-backdrop-blur relative overflow-hidden rounded-2xl border border-blue-400/20 px-8 py-3 text-base font-bold shadow-2xl transition-all duration-300 hover:scale-105 hover:shadow-blue-500/30 md:px-10 md:py-4 md:text-lg"
507-
style={{ display: "inline-flex", textDecoration: "none" }}
506+
className="courses-button-primary courses-button-link group courses-backdrop-blur relative overflow-hidden rounded-2xl border border-blue-400/20 px-8 py-3 text-base font-bold shadow-2xl transition-all duration-300 hover:scale-105 hover:shadow-blue-500/30 md:px-10 md:py-4 md:text-lg"
508507
>
509508
<span className="relative z-10 flex items-center justify-center gap-2">
510509
Explore Courses

0 commit comments

Comments
 (0)