-
Notifications
You must be signed in to change notification settings - Fork 137
Fix/ebooks searchbar theme dark mode #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanjay-kv
merged 2 commits into
recodehive:main
from
Sandesh282:fix/ebooks-searchbar-theme-dark-mode
Oct 26, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS variable
--ifm-color-mutedused for the placeholder color doesn't exist in Docusaurus v3. This will cause the placeholder text color to fall back to browser defaults, breaking the intended dark/light theme support.View Details
Analysis
Undefined CSS variable --ifm-color-muted breaks theme-aware placeholder color
What fails: Ebook search placeholder in
src/pages/ebooks/index.cssline 71 uses undefined--ifm-color-mutedvariable, causing placeholder text to fall back to browser defaults instead of Docusaurus theme colorsHow to reproduce:
Result: Placeholder text color ignores dark/light theme switching and uses browser default gray instead of theme-appropriate colors
Expected: Placeholder should use theme-aware colors that adapt to light/dark mode like other UI elements
Root cause:
--ifm-color-mutedis not defined in Docusaurus v3 Infima CSS variables. Verified by examiningnode_modules/infima/dist/css/default/default.css- only--ifm-color-content-secondary(#525860) exists for secondary text content.