-
Notifications
You must be signed in to change notification settings - Fork 138
fix(ui): reapply author profile CSS patches and resolve blog page overlap conflicts #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS class selector
.avatar.margin-bottom--sm.author-as-h1_iMAgappears nowhere in the codebase and will never match any HTML elements, making this fix ineffective.View Details
📝 Patch Details
Analysis
Ineffective CSS selector using non-existent class
author-as-h1_iMAgWhat fails: CSS rule
.avatar.margin-bottom--sm.author-as-h1_iMAgon line 1778 ofsrc/css/custom.cssnever matches any DOM elements because the classauthor-as-h1_iMAgdoes not exist in the rendered HTMLHow to reproduce:
Result: CSS styling for author avatars (150px sizing, border-radius) is never applied, leaving the original overlap issue unresolved
Expected: CSS selectors should match actual HTML structure. Docusaurus generates
<div class="avatar margin-bottom--sm">for blog author avatars, notauthor-as-h1_iMAgFix removes the non-existent class from the selector so the CSS rule actually applies to the intended elements.