Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
Agent-Logs-Url: https://github.com/recodehive/recode-website/sessions/2b0e0e44-7325-494a-adcf-d51ee605a1a0 Co-authored-by: sanjay-kv <30715153+sanjay-kv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix discussion tab not expanding or functional
Fix: Discussion cards non-functional — wire onClick to redirect to GitHub discussion
May 4, 2026
Adez017
approved these changes
May 4, 2026
Member
|
@Adez017 the issue raised and what it done is different right, there is already redirection to github working? |
Member
Currently only the title is redirecting and now this creates whole cards functional. Isn't it ? |
Member
|
thanks for clarification |
|
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. I would be grateful if you can nominate for keeping this opensource project live and running Link to Nominate. Please do star the repo and Keep up the fantastic work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiscussionCardhadcursor: pointerCSS but no click handler — only the title<a>tag was interactive. Clicking anywhere else on the card (body text, author, engagement stats) did nothing, making cards appear broken.Changes Made
src/components/discussions/DiscussionCard.tsxhandleCardClick→window.open(discussion.html_url, "_blank", "noopener,noreferrer")onClickso the entire card surface is clickablee.stopPropagation()on the inner title<a>to prevent double-navigationrole="button",tabIndex={0},onKeyDownhandles bothEnterandSpace,aria-labelDependencies
Checklist
npm run buildand attached screenshot(s) in this PR.