fix(layout): resolve algorithmic testimonial avatars on careers page - #1734
Conversation
|
@nishtha-agarwal-211 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
Bot
added
in-review
github-actions
Bot
added
Enhacement
|
✅ Synchronized metadata from Issue #1695:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Introduces a reusable avatar component for testimonials on the careers page, rendering either an image (with error fallback) or a default user icon.
Changes:
- Added
TestimonialAvatarcomponent with image loading + error fallback behavior. - Replaced duplicated testimonial avatar markup with
TestimonialAvatarin both dark/light carousel variants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5dff1a7 to
3b50dea
Compare
|
✅ Synchronized metadata from Issue #1695:
|
3b50dea to
9182dcf
Compare
|
✅ Synchronized metadata from Issue #1695:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
This Pull Request resolves the issue where the testimonial carousel on the Careers page (
/careers) ignored theavatarfield defined in the testimonials data and fell back to rendering a generic LucideUsericon. It also resolves the issue of missing testimonial image assets by leveraging pre-existing high-quality headshots already in the project repository.Fixes #1695
Proposed Changes
Leveraged Pre-existing Avatar Assets:
avatarpaths in thetestimonialsdata array (src/pages/careers/index.tsx) to reference the styled headshot images already available in/icons/(/icons/vivien.png,/icons/daniel.png, and/icons/ethan.png).Reusable
TestimonialAvatarComponent:<TestimonialAvatar />component insrc/pages/careers/index.tsxthat handles rendering testimonial avatar images with graceful error fallback.Usericon.Carousel Integration:
Usericon insrc/pages/careers/index.tsxwith the new<TestimonialAvatar />component in both the mounted dynamic carousel and the pre-hydration fallback container.