Skip to content

PR Modal close on Escape key press #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanjay-kv merged 1 commit into from
Oct 14, 2025
Merged

PR Modal close on Escape key press #931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/components/dashboard/LeaderBoard/PRListModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// src/components/dashboard/LeaderBoard/PRListModal.tsx
import React from "react";
import React, { useEffect } from "react";
import { motion, AnimatePresence } from "framer-motion";
import { FaTimes, FaExternalLinkAlt, FaGithub } from "react-icons/fa";
import { useColorMode } from "@docusaurus/theme-common";
Expand Down Expand Up @@ -64,12 +64,6 @@ export default function PRListModal({
}
};

const handleKeyDown = (e: React.KeyboardEvent) => {
if (e.key === "Escape") {
onClose();
}
};

// Helper function to get filter display text
const getFilterDisplayText = (filter: string) => {
switch (filter) {
Expand All @@ -94,6 +88,21 @@ export default function PRListModal({
return "#6b7280"; // Gray for no points
};

// Close modal on Escape key press
useEffect(() => {
if (!isOpen) return;
const handleEsc = (event: KeyboardEvent) => {
if (event.key === "Escape") {
onClose();
}
};

window.addEventListener("keydown", handleEsc);
return () => {
window.removeEventListener("keydown", handleEsc);
};
}, [isOpen])

return (
<AnimatePresence>
{isOpen && (
Expand All @@ -103,7 +112,6 @@ export default function PRListModal({
animate={{ opacity: 1 }}
exit={{ opacity: 0 }}
onClick={handleBackdropClick}
onKeyDown={handleKeyDown}
tabIndex={0}
role="dialog"
aria-modal="true"
Expand Down
Loading