Skip to content

fix(navbar): adjust hamburger menu breakpoint to 1024px for proper desktop display#960

Closed
sheikhlimon wants to merge 0 commit intorecodehive:mainfrom
sheikhlimon:fix-hamburger-menu
Closed

fix(navbar): adjust hamburger menu breakpoint to 1024px for proper desktop display#960
sheikhlimon wants to merge 0 commit intorecodehive:mainfrom
sheikhlimon:fix-hamburger-menu

Conversation

@sheikhlimon
Copy link
Copy Markdown
Contributor

Description

Fixed hamburger menu appearing on desktop screens by adjusting the responsive breakpoint from 1300px to 1024px.

Fixes #701

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

  • Breakpoint adjustment: Changed from 1300px/1299px to 1024px/1023px
  • Desktop behavior (≥1024px):
    • Hamburger toggle button hidden with display: none and pointer-events: none
    • Navbar sidebar and backdrop completely disabled
    • Navbar items displayed inline as normal desktop navigation
  • Mobile/Tablet behavior (<1024px):
    • Hamburger menu visible and functional
    • Navbar items hidden in top bar
    • Sidebar navigation enabled with proper styling

Why This Change

The previous 1300px breakpoint was too high, causing the hamburger menu to display on standard laptop screens (1280-1366px). The new 1024px breakpoint aligns better with common device sizes and ensures proper desktop navigation on most screens.

Dependencies

No dependencies added or updated.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Oct 19, 2025

@sheikhlimon is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

Synced data from Linked Issues

Labels:

  • full-test-needed
  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • Harshvardhan-91

Milestones:

  • recode:launch 3.0

@github-actions
Copy link
Copy Markdown

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions Bot added hacktoberfest-accepted recode this is label for leaderboard labels Oct 19, 2025
@sheikhlimon
Copy link
Copy Markdown
Contributor Author

@sanjay-kv this is pretty complicated. this fixes one thing but breaks another .... infact css probably has nothing to do with this.. it could be because of localStorage blocked due sandboxing ... i need to work on this

@sheikhlimon sheikhlimon deleted the fix-hamburger-menu branch October 19, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted recode this is label for leaderboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Menu button is not working on home page

1 participant