Implemented watch reaction functions (#1)

Adding watch reactor functions

Author: AshishNaware

testing/client.go

@@ -23,10 +23,13 @@ import (
 
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+	"k8s.io/apimachinery/pkg/watch"
 	clientgotesting "k8s.io/client-go/testing"
 	ref "k8s.io/client-go/tools/reference"
+	"reconciler.io/runtime/duck"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
@@ -146,6 +149,20 @@ func (w *clientWrapper) react(action Action) error {
 	return nil
 }
 
+func (w *clientWrapper) reactWatcherFunc(action Action) error {
+	for _, reactor := range w.watchReactionChain {
+		if !reactor.Handles(action) {
+			continue
+		}
+		handled, _, err := reactor.React(action)
+		if !handled {
+			continue
+		}
+		return err
+	}
+	return nil
+}
+
 func (w *clientWrapper) Scheme() *runtime.Scheme {
 	return w.client.Scheme()
 }
@@ -313,6 +330,55 @@ func (w *clientWrapper) DeleteAllOf(ctx context.Context, obj client.Object, opts
 	return w.client.DeleteAllOf(ctx, obj, opts...)
 }
 
+func (w *clientWrapper) Watch(ctx context.Context, list client.ObjectList, opts ...client.ListOption) (watch.Interface, error) {
+
+	ww, ok := w.client.(client.WithWatch)
+	if !ok {
+		panic(fmt.Errorf("unable to call Watch with wrapped client that does not implement client.WithWatch"))
+	}
+
+	gvr, namespace, name, err := w.objmeta(list)
+	if err != nil {
+		return nil, err
+	}
+
+	// call reactor chain
+	err = w.reactWatcherFunc(clientgotesting.NewGetAction(gvr, namespace, name))
+	if err != nil {
+		return nil, err
+	}
+	err = w.reactWatcherFunc(clientgotesting.NewCreateAction(gvr, namespace, list))
+	if err != nil {
+		return nil, err
+	}
+	err = w.reactWatcherFunc(clientgotesting.NewDeleteAction(gvr, namespace, name))
+	if err != nil {
+		return nil, err
+	}
+	err = w.reactWatcherFunc(clientgotesting.NewUpdateAction(gvr, namespace, list))
+	if err != nil {
+		return nil, err
+	}
+
+	if !duck.IsDuck(list, w.Scheme()) {
+		return ww.Watch(ctx, list, opts...)
+	}
+
+	uObj, err := runtime.DefaultUnstructuredConverter.ToUnstructured(list)
+	if err != nil {
+		return nil, err
+	}
+	u := &unstructured.UnstructuredList{Object: uObj}
+	watcher, err := ww.Watch(ctx, u, opts...)
+	if err != nil {
+		return nil, err
+	}
+	if err := runtime.DefaultUnstructuredConverter.FromUnstructured(u.Object, list); err != nil {
+		return nil, err
+	}
+	return watcher, nil
+}
+
 func (w *clientWrapper) Status() client.StatusWriter {
 	return &statusWriterWrapper{
 		statusWriter:  w.client.Status(),

testing/reconciler.go

@@ -48,9 +48,10 @@ type ReconcilerTestCase struct {
 
 	// Request identifies the object to be reconciled
 	Request reconcilers.Request
-	// WithReactors installs each ReactionFunc into each fake clientset. ReactionFuncs intercept
+	// WithReactors and WithWatchReactors installs each ReactionFunc into each fake clientset. ReactionFuncs intercept
 	// each call to the clientset providing the ability to mutate the resource or inject an error.
-	WithReactors []ReactionFunc
+	WithReactors      []ReactionFunc
+	WithWatchReactors []WatchReactionFunc
 	// WithClientBuilder allows a test to modify the fake client initialization.
 	WithClientBuilder func(*fake.ClientBuilder) *fake.ClientBuilder
 	// StatusSubResourceTypes is a set of object types that support the status sub-resource. For
@@ -188,6 +189,7 @@ func (tc *ReconcilerTestCase) Run(t *testing.T, scheme *runtime.Scheme, factory
 		APIGivenObjects:         tc.APIGivenObjects,
 		WithClientBuilder:       tc.WithClientBuilder,
 		WithReactors:            tc.WithReactors,
+		WithWatchReactors:       tc.WithWatchReactors,
 		GivenTracks:             tc.GivenTracks,
 		ExpectTracks:            tc.ExpectTracks,
 		ExpectEvents:            tc.ExpectEvents,

testing/subreconciler.go

@@ -56,9 +56,10 @@ type SubReconcilerTestCase[Type client.Object] struct {
 	GivenStashedValues map[reconcilers.StashKey]interface{}
 	// WithClientBuilder allows a test to modify the fake client initialization.
 	WithClientBuilder func(*fake.ClientBuilder) *fake.ClientBuilder
-	// WithReactors installs each ReactionFunc into each fake clientset. ReactionFuncs intercept
+	// WithReactors and WithWatchReactors installs each ReactionFunc into each fake clientset. ReactionFuncs intercept
 	// each call to the clientset providing the ability to mutate the resource or inject an error.
-	WithReactors []ReactionFunc
+	WithReactors      []ReactionFunc
+	WithWatchReactors []WatchReactionFunc
 	// StatusSubResourceTypes is a set of object types that support the status sub-resource. For
 	// these types, the only way to modify the resource's status is update or patch the status
 	// sub-resource. Patching or updating the main resource will not mutated the status field.
@@ -216,6 +217,7 @@ func (tc *SubReconcilerTestCase[T]) Run(t *testing.T, scheme *runtime.Scheme, fa
 		APIGivenObjects:         append(tc.APIGivenObjects, givenResource),
 		WithClientBuilder:       tc.WithClientBuilder,
 		WithReactors:            tc.WithReactors,
+		WithWatchReactors:       tc.WithWatchReactors,
 		GivenTracks:             tc.GivenTracks,
 		ExpectTracks:            tc.ExpectTracks,
 		ExpectEvents:            tc.ExpectEvents,

testing/webhook.go

@@ -54,9 +54,10 @@ type AdmissionWebhookTestCase struct {
 	HTTPRequest *http.Request
 	// WithClientBuilder allows a test to modify the fake client initialization.
 	WithClientBuilder func(*fake.ClientBuilder) *fake.ClientBuilder
-	// WithReactors installs each ReactionFunc into each fake clientset. ReactionFuncs intercept
+	// WithReactors and WithWatchReactors installs each ReactionFunc into each fake clientset. ReactionFuncs intercept
 	// each call to the clientset providing the ability to mutate the resource or inject an error.
-	WithReactors []ReactionFunc
+	WithReactors      []ReactionFunc
+	WithWatchReactors []WatchReactionFunc
 	// StatusSubResourceTypes is a set of object types that support the status sub-resource. For
 	// these types, the only way to modify the resource's status is update or patch the status
 	// sub-resource. Patching or updating the main resource will not mutated the status field.
@@ -181,6 +182,7 @@ func (tc *AdmissionWebhookTestCase) Run(t *testing.T, scheme *runtime.Scheme, fa
 		APIGivenObjects:         tc.APIGivenObjects,
 		WithClientBuilder:       tc.WithClientBuilder,
 		WithReactors:            tc.WithReactors,
+		WithWatchReactors:       tc.WithWatchReactors,
 		GivenTracks:             tc.GivenTracks,
 		ExpectTracks:            tc.ExpectTracks,
 		ExpectEvents:            tc.ExpectEvents,