-
Notifications
You must be signed in to change notification settings - Fork 64
Expand file tree
/
Copy pathExtractArrayArgOnQueryBuilderSelectRector.php
More file actions
103 lines (88 loc) · 2.64 KB
/
ExtractArrayArgOnQueryBuilderSelectRector.php
File metadata and controls
103 lines (88 loc) · 2.64 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
<?php
declare(strict_types=1);
namespace Rector\Doctrine\Dbal211\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\ArrayItem;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\MethodCall;
use PHPStan\Type\ObjectType;
use Rector\Doctrine\Enum\DoctrineClass;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://github.com/doctrine/dbal/pull/3853
* @changelog https://github.com/doctrine/dbal/issues/3837
*
* @see \Rector\Doctrine\Tests\Dbal211\Rector\MethodCall\ExtractArrayArgOnQueryBuilderSelectRector\ExtractArrayArgOnQueryBuilderSelectRectorTest
*/
final class ExtractArrayArgOnQueryBuilderSelectRector extends AbstractRector
{
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Extract array arg on QueryBuilder select, addSelect, groupBy, addGroupBy',
[
new CodeSample(
<<<'CODE_SAMPLE'
function query(\Doctrine\DBAL\Query\QueryBuilder $queryBuilder)
{
$query = $queryBuilder->select(['u.id', 'p.id']);
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
function query(\Doctrine\DBAL\Query\QueryBuilder $queryBuilder)
{
$query = $queryBuilder->select('u.id', 'p.id');
}
CODE_SAMPLE
),
]
);
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node): ?MethodCall
{
$varType = $this->nodeTypeResolver->getType($node->var);
if (! $varType instanceof ObjectType) {
return null;
}
if (! $varType->isInstanceOf(DoctrineClass::DBAL_QUERY_BUILDER)->yes()) {
return null;
}
if (! $this->isNames($node->name, ['select', 'addSelect', 'groupBy', 'addGroupBy'])) {
return null;
}
if ($node->isFirstClassCallable()) {
return null;
}
$args = $node->getArgs();
if (count($args) !== 1) {
return null;
}
$currentArg = $args[0]->value;
if (! $currentArg instanceof Array_) {
return null;
}
$newArgs = [];
foreach ($currentArg->items as $value) {
if (! $value instanceof ArrayItem) {
return null;
}
$newArgs[] = new Arg($value->value);
}
$node->args = $newArgs;
return $node;
}
}