fix reprint of type in CollectionSetterParamNativeTypeRector (#418)

* add failing fixture

* fix reprint of type in CollectionSetterParamNativeTypeRector

Author: TomasVotruba

rules/TypedCollections/Rector/ClassMethod/CollectionParamTypeSetterToCollectionPropertyRector.php

@@ -108,6 +108,7 @@ public function refactor(Node $node): ?ClassMethod
             // remove default param, as no longer needed
             if ($firstParam->default instanceof Expr) {
                 $firstParam->default = null;
+
                 return $node;
             }
 

rules/TypedCollections/Rector/ClassMethod/CollectionSetterParamNativeTypeRector.php

@@ -16,6 +16,7 @@
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Doctrine\Enum\DoctrineClass;
 use Rector\Doctrine\TypedCollections\DocBlockAnalyzer\CollectionTagValueNodeAnalyzer;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -120,6 +121,9 @@ public function refactor(Node $node): ?ClassMethod
             $hasChanged = true;
             $param->type = new FullyQualified(DoctrineClass::COLLECTION);
 
+            // fix reprint position of type
+            $param->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+
             // make nullable only 1st param, as others might require a null
             if ($param->default instanceof Expr) {
                 if ($isInTests === false) {

tests/Set/TypedCollections/Fixture/param_type_position.php.inc

@@ -0,0 +1,52 @@
+<?php
+
+namespace Rector\Doctrine\Tests\Set\TypedCollections\Fixture;
+
+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\ODM\MongoDB\DocumentManager;
+
+final class ParamTypePosition
+{
+    private array $items;
+
+    /**
+     * @param mixed[]|ArrayCollection $collection
+     */
+    public function __construct(
+        private readonly DocumentManager $documentManager,
+        private $collection
+    ) {
+        foreach ($this->collection as $item) {
+            $this->items[] = $item;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Doctrine\Tests\Set\TypedCollections\Fixture;
+
+use Doctrine\Common\Collections\Collection;
+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\ODM\MongoDB\DocumentManager;
+
+final class ParamTypePosition
+{
+    private array $items;
+
+    /**
+     * @param Collection<int, mixed> $collection
+     */
+    public function __construct(
+        private readonly DocumentManager $documentManager,
+        private Collection $collection
+    ) {
+        foreach ($this->collection as $item) {
+            $this->items[] = $item;
+        }
+    }
+}
+
+?>