[deprecated] Remove deprecated MakeEntityDateTimePropertyDateTimeInterfaceRector (#376)

Author: TomasVotruba

phpstan.neon

@@ -53,10 +53,6 @@ parameters:
         # debug function
         - '#Function "d\(\)" cannot be used/left in the code#'
 
-        -
-            identifier: classConstant.deprecatedClass
-            path: rules-tests/CodeQuality/Rector/Property/MakeEntityDateTimePropertyDateTimeInterfaceRector/config/configured_rule.php
-
         -
             message: '#Parameter (.*?) \$desiredClass of method Rector\\BetterPhpDocParser\\PhpDocInfo\\PhpDocInfo::findByAnnotationClass\(\) expects class-string, string given#'
             path: src/NodeAnalyzer/AttrinationFinder.php

rules-tests/CodeQuality/Rector/Property/MakeEntityDateTimePropertyDateTimeInterfaceRector/Fixture/fixture.php.inc

@@ -4,6 +4,12 @@
 
 namespace Rector\Doctrine\Bundle230\Rector\Class_;
 
+use PhpParser\Node\Name;
+use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\Node\Stmt\Expression;
+use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Identifier;
+use PhpParser\Node\Arg;
 use PhpParser\Node;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Stmt\Class_;
@@ -21,14 +27,8 @@
  */
 final class AddAnnotationToRepositoryRector extends AbstractRector
 {
-    private DocBlockUpdater $docBlockUpdater;
-
-    private PhpDocInfoFactory $phpDocInfoFactory;
-
-    public function __construct(DocBlockUpdater $docBlockUpdater, PhpDocInfoFactory $phpDocInfoFactory)
+    public function __construct(private readonly DocBlockUpdater $docBlockUpdater, private readonly PhpDocInfoFactory $phpDocInfoFactory)
     {
-        $this->docBlockUpdater = $docBlockUpdater;
-        $this->phpDocInfoFactory = $phpDocInfoFactory;
     }
 
     public function getRuleDefinition(): RuleDefinition
@@ -80,14 +80,15 @@ public function refactor(Node $node): ?Node
         if ($entityClass === null || $this->hasExtendsAnnotation($node)) {
             return null;
         }
+
         $this->addAnnotationToNode($node, $entityClass);
 
         return $node;
     }
 
     private function isRepositoryClass(Class_ $class): bool
     {
-        if ($class->extends instanceof Node\Name) {
+        if ($class->extends instanceof Name) {
             return $this->getName(
                 $class->extends
             ) === 'Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository';
@@ -99,17 +100,17 @@ private function isRepositoryClass(Class_ $class): bool
     private function getEntityClassFromConstructor(Class_ $class): ?string
     {
         $method = $class->getMethod(MethodName::CONSTRUCT);
-        if ($method === null || $method->stmts === null) {
+        if (!$method instanceof ClassMethod || $method->stmts === null) {
             return null;
         }
 
         foreach ($method->stmts as $stmt) {
-            if (! $stmt instanceof Node\Stmt\Expression) {
+            if (! $stmt instanceof Expression) {
                 continue;
             }
 
             $expr = $stmt->expr;
-            if (! $expr instanceof Node\Expr\StaticCall) {
+            if (! $expr instanceof StaticCall) {
                 continue;
             }
 
@@ -124,7 +125,7 @@ private function getEntityClassFromConstructor(Class_ $class): ?string
 
             $entityClass = $entityClassNode->class;
 
-            return $entityClass instanceof Node\Name
+            return $entityClass instanceof Name
                 ? $entityClass->toString()
                 : null;
         }
@@ -147,14 +148,14 @@ private function hasExtendsAnnotation(Class_ $class): bool
             ->hasByName('@extends');
     }
 
-    private function isParentConstructorCall(Node\Expr\StaticCall $expr): bool
+    private function isParentConstructorCall(StaticCall $staticCall): bool
     {
-        return $expr->class instanceof Node\Name
-            && $expr->class->toString() === 'parent'
-            && $expr->name instanceof Node\Identifier
-            && $expr->name->toString() === '__construct'
-            && isset($expr->args[1])
-            && $expr->args[1] instanceof Node\Arg  // Controleer of args[1] een Node\Arg is
-            && $expr->args[1]->value instanceof ClassConstFetch;
+        return $staticCall->class instanceof Name
+            && $staticCall->class->toString() === 'parent'
+            && $staticCall->name instanceof Identifier
+            && $staticCall->name->toString() === '__construct'
+            && isset($staticCall->args[1])
+            && $staticCall->args[1] instanceof Arg  // Controleer of args[1] een Node\Arg is
+            && $staticCall->args[1]->value instanceof ClassConstFetch;
     }
 }