skip assign of New_ to CollectionParamTypeSetterToCollectionPropertyRector (#419)

* add failing fixture

* skip assign of New_ to CollectionParamTypeSetterToCollectionPropertyRector

Author: TomasVotruba

rules-tests/TypedCollections/Rector/ClassMethod/CollectionParamTypeSetterToCollectionPropertyRector/Fixture/skip_constructor_setter.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Doctrine\Tests\TypedCollections\Rector\ClassMethod\CollectionParamTypeSetterToCollectionPropertyRector\Fixture;
+
+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\Common\Collections\Collection;
+
+final class SkipConstructorSetter
+{
+    /**
+     * @var Collection<int, string>
+     */
+    public $items;
+
+    public function __construct($item)
+    {
+        $this->items = new ArrayCollection([]);
+    }
+}

rules-tests/TypedCollections/Rector/If_/RemoveIfInstanceofCollectionRector/Fixture/skip_non_collection.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Doctrine\Tests\TypedCollections\Rector\If_\RemoveIfInstanceofCollectionRector\Fixture;
+
+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\Common\Collections\Collection;
+use Rector\Doctrine\Tests\TypedCollections\Rector\If_\RemoveIfInstanceofCollectionRector\Source\SomeInstance;
+
+final class SkipNonCollection
+{
+    public Collection $items;
+
+    public function __construct($item)
+    {
+        $this->items = new ArrayCollection();
+        if ($item instanceof SomeInstance) {
+            echo 'check';
+        }
+    }
+}
+
+?>

rules-tests/TypedCollections/Rector/If_/RemoveIfInstanceofCollectionRector/Source/SomeInstance.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\Doctrine\Tests\TypedCollections\Rector\If_\RemoveIfInstanceofCollectionRector\Source;
+
+class SomeInstance
+{
+
+}

rules-tests/TypedCollections/Rector/MethodCall/SetArrayToNewCollectionRector/Fixture/new_instance.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Fixture;
+
+use Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Source\ItemType;
+use Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Source\SomeClassWithConstructorCollection;
+use Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Source\SomeClassWithSetter;
+
+final class NewInstance
+{
+    public function run()
+    {
+        $someVariable = [new ItemType(), new ItemType()];
+
+        $someClassWithSetter = new SomeClassWithConstructorCollection($someVariable);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Fixture;
+
+use Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Source\ItemType;
+use Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Source\SomeClassWithConstructorCollection;
+use Rector\Doctrine\Tests\TypedCollections\Rector\MethodCall\SetArrayToNewCollectionRector\Source\SomeClassWithSetter;
+
+final class NewInstance
+{
+    public function run()
+    {
+        $someVariable = [new ItemType(), new ItemType()];
+
+        $someClassWithSetter = new SomeClassWithConstructorCollection(new \Doctrine\Common\Collections\ArrayCollection($someVariable));
+    }
+}
+
+?>

rules/TypedCollections/Rector/ClassMethod/CollectionParamTypeSetterToCollectionPropertyRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Assign;
+use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
@@ -131,6 +132,10 @@ private function isAssignToPropertyFetchCollection(Assign $assign): bool
             return false;
         }
 
+        if ($assign->expr instanceof New_) {
+            return false;
+        }
+
         $propertyFetchType = $this->getType($assign->var);
         if (! $propertyFetchType instanceof ObjectType) {
             return false;