[CodeQuality] Keep param/return with description on TypeNullableEntityFromDocblockRector (#460)

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/TypeNullableEntityFromDocblockRector/Fixture/docblock_entity_with_param_return_description.php.inc

@@ -0,0 +1,76 @@
+<?php
+
+namespace Rector\Doctrine\Tests\CodeQuality\Rector\Class_\TypeNullableEntityFromDocblockRector\Fixture;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class DocblockEntityWithParamReturnDescription
+{
+    /**
+     * @var string
+     * @ORM\Id
+     * @ORM\Column(type="string")
+     * @ORM\GeneratedValue
+     */
+    private $name;
+
+    /**
+     * @return string some description
+     */
+    public function getName()
+    {
+        return $this->name;
+    }
+
+    /**
+     * @param string $name some description
+     */
+    public function setName($name): void
+    {
+        $this->name = $name;
+    }
+}
+
+
+?>
+-----
+<?php
+
+namespace Rector\Doctrine\Tests\CodeQuality\Rector\Class_\TypeNullableEntityFromDocblockRector\Fixture;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class DocblockEntityWithParamReturnDescription
+{
+    /**
+     * @ORM\Id
+     * @ORM\Column(type="string")
+     * @ORM\GeneratedValue
+     */
+    private ?string $name = null;
+
+    /**
+     * @return string some description
+     */
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    /**
+     * @param string $name some description
+     */
+    public function setName(?string $name): void
+    {
+        $this->name = $name;
+    }
+}
+
+
+?>

rules/CodeQuality/Rector/Class_/TypeNullableEntityFromDocblockRector.php

@@ -267,6 +267,11 @@ private function removeParamDocblock(ClassMethod $classMethod): void
             return;
         }
 
+        $paramTagValueNode = $classMethodPhpDocInfo->getParamTagValueNodes()[0] ?? null;
+        if ($paramTagValueNode instanceof ParamTagValueNode && $paramTagValueNode->description !== '') {
+            return;
+        }
+
         $classMethodPhpDocInfo->removeByType(ParamTagValueNode::class);
         $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($classMethod);
     }
@@ -282,6 +287,10 @@ private function removeReturnDocblock(ClassMethod $classMethod): void
             return;
         }
 
+        if ($classMethodPhpDocInfo->getReturnTagValue()->description !== '') {
+            return;
+        }
+
         $classMethodPhpDocInfo->removeByType(ReturnTagValueNode::class);
         $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($classMethod);
     }