skip is_array() on anything (#422)

Author: TomasVotruba

rules-tests/TypedCollections/Rector/If_/RemoveIsArrayOnCollectionRector/Fixture/skip_is_array_on_non_collection.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Doctrine\Tests\TypedCollections\Rector\If_\RemoveIsArrayOnCollectionRector\Fixture;
+
+use Doctrine\Common\Collections\Collection;
+
+final class SkipIsArrayOnNonCollection
+{
+    public $items;
+
+    public function someMethod()
+    {
+        return ! is_array($this->items) ? $this->items : [];
+    }
+
+    public function nextMethod()
+    {
+        return is_array($this->items) ? $this->items : [];
+    }
+
+    public function condition()
+    {
+        if (! is_array($this->items)) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+}

rules/TypedCollections/Rector/If_/RemoveIsArrayOnCollectionRector.php

@@ -88,7 +88,10 @@ private function refactorIf(If_ $if): array|int|null
         if ($if->cond instanceof BooleanNot) {
             $condition = $if->cond->expr;
 
-            if ($condition instanceof FuncCall && $this->isName($condition, 'is_array')) {
+            if ($condition instanceof FuncCall && $this->isName(
+                $condition,
+                'is_array'
+            ) && $this->collectionTypeDetector->isCollectionType($condition->getArgs()[0] ->value)) {
                 return $if->stmts;
             }