Skip to content

fix document service repository class #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Sep 8, 2025
Merged

fix document service repository class #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...r/Class_/AddAnnotationToRepositoryRector/Fixture/some_service_document_repository.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use Doctrine\Persistence\ManagerRegistry;
use App\Entity\SomeEntity;

/**
* @extends \Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository<\App\Entity\SomeEntity>
* @extends \Doctrine\Bundle\MongoDBBundle\Repository\ServiceDocumentRepository<\App\Entity\SomeEntity>
*/
final class SomeServiceDocumentRepository extends ServiceDocumentRepository
{
Expand Down
22 changes: 13 additions & 9 deletions rules/Bundle230/Rector/Class_/AddAnnotationToRepositoryRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ public function getNodeTypes(): array
*/
public function refactor(Node $node): ?Node
{
if (! $this->isRepositoryClass($node)) {
$repositoryClass = $this->matchServiceRepositoryClass($node);
if ($repositoryClass === null) {
return null;
}

Expand All @@ -95,22 +96,25 @@ public function refactor(Node $node): ?Node
return null;
}

$this->addAnnotationToNode($node, $entityClass);
$this->addAnnotationToNode($node, $entityClass, $repositoryClass);

return $node;
}

private function isRepositoryClass(Class_ $class): bool
private function matchServiceRepositoryClass(Class_ $class): ?string
{
if (! $class->extends instanceof Name) {
return false;
return null;
}

if ($this->isName($class->extends, DoctrineClass::SERVICE_ENTITY_REPOSITORY)) {
return true;
if (! $this->isNames(
$class->extends,
[DoctrineClass::SERVICE_ENTITY_REPOSITORY, DoctrineClass::SERVICE_DOCUMENT_REPOSITORY]
)) {
return null;
}

return $this->isName($class->extends, DoctrineClass::SERVICE_DOCUMENT_REPOSITORY);
return $this->getName($class->extends);
}

private function getEntityClassFromConstructor(Class_ $class): ?string
Expand Down Expand Up @@ -149,11 +153,11 @@ private function getEntityClassFromConstructor(Class_ $class): ?string
return null;
}

private function addAnnotationToNode(Class_ $class, string $entityClass): void
private function addAnnotationToNode(Class_ $class, string $entityClass, string $repositoryClass): void
{
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($class);

$genericsAnnotation = sprintf('\%s<\%s>', DoctrineClass::SERVICE_ENTITY_REPOSITORY, $entityClass);
$genericsAnnotation = sprintf('\%s<\%s>', $repositoryClass, $entityClass);
$phpDocInfo->addPhpDocTagNode(new PhpDocTagNode('@extends', new GenericTagValueNode($genericsAnnotation)));

$this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($class);
Expand Down