-
Notifications
You must be signed in to change notification settings - Fork 25
Expand file tree
/
Copy pathDowngradeTrailingCommasInFunctionCallsRector.php
More file actions
109 lines (96 loc) · 2.86 KB
/
DowngradeTrailingCommasInFunctionCallsRector.php
File metadata and controls
109 lines (96 loc) · 2.86 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
<?php
declare(strict_types=1);
namespace Rector\DowngradePhp73\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\StaticCall;
use Rector\DowngradePhp73\Tokenizer\FollowedByCommaAnalyzer;
use Rector\DowngradePhp73\Tokenizer\TrailingCommaRemover;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DowngradePhp73\Rector\FuncCall\DowngradeTrailingCommasInFunctionCallsRector\DowngradeTrailingCommasInFunctionCallsRectorTest
*/
final class DowngradeTrailingCommasInFunctionCallsRector extends AbstractRector
{
public function __construct(
private readonly FollowedByCommaAnalyzer $followedByCommaAnalyzer,
private readonly TrailingCommaRemover $trailingCommaRemover
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Remove trailing commas in function calls',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function __construct(string $value)
{
$compacted = compact(
'posts',
'units',
);
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function __construct(string $value)
{
$compacted = compact(
'posts',
'units'
);
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [FuncCall::class, MethodCall::class, StaticCall::class, New_::class];
}
/**
* @param FuncCall|MethodCall|StaticCall|New_ $node
*/
public function refactor(Node $node): ?Node
{
if ($node->isFirstClassCallable()) {
return null;
}
$args = $node->getArgs();
if ($args === []) {
return null;
}
// reprint is needed as position changed that can't rely on token position
// @see https://github.com/rectorphp/rector-downgrade-php/pull/281
// @see https://github.com/rectorphp/rector-downgrade-php/pull/285
foreach ($args as $arg) {
if ($arg->getEndTokenPos() < 0) {
$node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
return $node;
}
}
$lastArgKey = count($args) - 1;
$lastArg = $args[$lastArgKey];
if (! $this->followedByCommaAnalyzer->isFollowed($this->file, $lastArg)) {
return null;
}
$this->trailingCommaRemover->remove($this->file, $lastArg);
return $node;
}
}