[DowngradePhp80] Handle combine DowngradeMixedTypeDeclarationRector+DowngradeAttributeToAnnotationRector on declare(strict_types=1) inline after open php tag (#373)

* [DowngradePhp80] Handle combine DowngradeMixedTypeDeclarationRector+DowngradeAttributeToAnnotationRector on declare(strict_types=1) inline after open php tag

* Fix

* Fix

* Fix

* fix phpstan

* fix phpstan

Author: samsonasik

rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php

@@ -118,16 +118,19 @@ public function refactor(Node $node): ?Node
         foreach ($node->attrGroups as $attrGroup) {
             foreach ($attrGroup->attrs as $key => $attribute) {
                 if ($this->shouldSkipAttribute($attribute)) {
-                    if (isset($oldTokens[$attrGroup->getEndTokenPos() + 1]) && ! str_contains(
-                        (string) $oldTokens[$attrGroup->getEndTokenPos() + 1],
-                        "\n"
-                    )) {
+                    $endTokenPos = $attrGroup->getEndTokenPos();
+                    $nextTokenPos = $endTokenPos + 1;
+                    if (
+                        $endTokenPos >= 0
+                        && isset($oldTokens[$nextTokenPos])
+                        && ! str_contains((string) $oldTokens[$nextTokenPos], "\n")
+                    ) {
                         // add new line
-                        $oldTokens[$attrGroup->getEndTokenPos() + 1]->text = "\n" . $this->resolveIndentation(
+                        $oldTokens[$nextTokenPos]->text = "\n" . $this->resolveIndentation(
                             $node,
                             $attrGroup,
                             $attribute
-                        ) . $oldTokens[$attrGroup->getEndTokenPos() + 1]->text;
+                        ) . $oldTokens[$nextTokenPos]->text;
                         $this->isDowngraded = true;
                     }
 

tests/Issues/IssueDowngradeMixedType/Fixture/do_not_add_newline_before_open_tag.php.inc

@@ -0,0 +1,35 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Tests\Issues\IssueDowngradeMixedType\Fixture;
+
+class SkipSameLineDeclareStrictType extends \stdClass implements \ArrayAccess, \Countable, \IteratorAggregate
+{
+    public function offsetGet($key): mixed
+    {
+    }
+}
+
+?>
+-----
+<?php declare(strict_types=1);
+
+namespace Rector\Tests\Issues\IssueDowngradeMixedType\Fixture;
+
+use stdClass;
+use ArrayAccess;
+use Countable;
+use IteratorAggregate;
+use ReturnTypeWillChange;
+
+class SkipSameLineDeclareStrictType extends stdClass implements ArrayAccess, Countable, IteratorAggregate
+{
+    /**
+     * @return mixed
+     */
+    #[ReturnTypeWillChange]
+    public function offsetGet($key)
+    {
+    }
+}
+
+?>

tests/Issues/IssueDowngradeMixedType/config/configured_rule.php

@@ -4,10 +4,17 @@
 
 use Rector\Config\RectorConfig;
 use Rector\DowngradePhp74\Rector\Property\DowngradeTypedPropertyRector;
+use Rector\DowngradePhp80\Rector\Class_\DowngradeAttributeToAnnotationRector;
 use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeMixedTypeDeclarationRector;
+use Rector\DowngradePhp80\ValueObject\DowngradeAttributeToAnnotation;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->importNames();
     $rectorConfig->rule(DowngradeTypedPropertyRector::class);
     $rectorConfig->rule(DowngradeMixedTypeDeclarationRector::class);
+
+    $rectorConfig
+        ->ruleWithConfiguration(DowngradeAttributeToAnnotationRector::class, [
+            new DowngradeAttributeToAnnotation('Symfony\Contracts\Service\Attribute\Required', 'required'),
+        ]);
 };