misc

Author: TomasVotruba

README.md

@@ -19,14 +19,10 @@ composer require rector/rector --dev
 To add a set to your config, use `Rector\Set\ValueObject\DowngradeLevelSetList` class and pick target set:
 
 ```php
-use Rector\Set\ValueObject\DowngradeLevelSetList;
 use Rector\Config\RectorConfig;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->sets([
-        DowngradeLevelSetList::DOWN_TO_PHP_72
-    ]);
-};
+return RectorConfig::configure()
+     ->withDowngradeSets(php74: true);
 ```
 
 Then run Rector to downgrade your code to PHP 7.2!

rules/DowngradePhp73/Rector/ConstFetch/DowngradePhp73JsonConstRector.php

@@ -63,12 +63,12 @@ public function getRuleDefinition(): RuleDefinition
 CODE_SAMPLE
                     ,
                     <<<'CODE_SAMPLE'
-$json json_encode($content, 0);
+$json = json_encode($content);
 if (json_last_error() !== JSON_ERROR_NONE) {
     throw new \Exception(json_last_error_msg());
 }
 
-$content = json_decode($json, null, 512, 0);
+$content = json_decode($json, null, 512);
 if (json_last_error() !== JSON_ERROR_NONE) {
     throw new \Exception(json_last_error_msg());
 }
@@ -149,22 +149,26 @@ private function resolveFuncCall(Expression $Expression): ?FuncCall
      *
      * @return null|array<Expression|If_>
      */
-    private function refactorStmt(Expression $Expression): ?array
+    private function refactorStmt(Expression $expression): ?array
     {
-        if ($Expression->getAttribute(AttributeKey::IS_IN_TRY_BLOCK) === true) {
+        if ($expression->getAttribute(AttributeKey::IS_IN_TRY_BLOCK) === true) {
             return null;
         }
 
         // retrieve a `FuncCall`, if any, from the statement
-        $funcCall = $this->resolveFuncCall($Expression);
+        $funcCall = $this->resolveFuncCall($expression);
 
         // Nothing to do if no `FuncCall` found
         if (! $funcCall instanceof FuncCall) {
             return null;
         }
 
+        if ($funcCall->isFirstClassCallable()) {
+            return null;
+        }
+
         // Nothing to do if not a refactored function
-        if (! in_array($this->getName($funcCall), self::REFACTOR_FUNCS, true)) {
+        if (! $this->isNames($funcCall, self::REFACTOR_FUNCS)) {
             return null;
         }
 
@@ -173,7 +177,7 @@ private function refactorStmt(Expression $Expression): ?array
             return null;
         }
 
-        $nodes = [$Expression];
+        $nodes = [$expression];
         $nodes[] = new If_(
             new NotIdentical(
                 new FuncCall(new Name('json_last_error')),