-
Notifications
You must be signed in to change notification settings - Fork 65
Expand file tree
/
Copy pathCreateStubOverCreateMockArgRector.php
More file actions
132 lines (110 loc) · 3.28 KB
/
CreateStubOverCreateMockArgRector.php
File metadata and controls
132 lines (110 loc) · 3.28 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
<?php
declare(strict_types=1);
namespace Rector\PHPUnit\PHPUnit120\Rector\CallLike;
use PhpParser\Node;
use PhpParser\Node\ArrayItem;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Identifier;
use Rector\PHPStan\ScopeFetcher;
use Rector\PHPUnit\Enum\PHPUnitClassName;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* Related change in PHPUnit 12 https://phpunit.expert/articles/testing-with-and-without-dependencies.html
*
* @see \Rector\PHPUnit\Tests\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector\CreateStubOverCreateMockArgRectorTest
*/
final class CreateStubOverCreateMockArgRector extends AbstractRector
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Use createStub() over createMock() when used as argument or array value and does not add any mock requirements',
[
new CodeSample(
<<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
final class SomeTest extends TestCase
{
public function test()
{
$this->someMethod($this->createMock(SomeClass::class));
}
private function someMethod($someClass)
{
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
final class SomeTest extends TestCase
{
public function test()
{
$this->someMethod($this->createStub(SomeClass::class));
}
private function someMethod($someClass)
{
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [StaticCall::class, MethodCall::class, New_::class, ArrayItem::class];
}
/**
* @param MethodCall|StaticCall|New_|ArrayItem $node
*/
public function refactor(Node $node): MethodCall|StaticCall|New_|ArrayItem|null
{
$scope = ScopeFetcher::fetch($node);
if (! $scope->isInClass()) {
return null;
}
$classReflection = $scope->getClassReflection();
if (! $classReflection->is(PHPUnitClassName::TEST_CASE)) {
return null;
}
if ($node instanceof ArrayItem) {
if (! $node->value instanceof MethodCall) {
return null;
}
$methodCall = $node->value;
if (! $this->isName($methodCall->name, 'createMock')) {
return null;
}
$methodCall->name = new Identifier('createStub');
return $node;
}
$hasChanges = false;
if ($node->isFirstClassCallable()) {
return null;
}
foreach ($node->getArgs() as $arg) {
if (! $arg->value instanceof MethodCall) {
continue;
}
$methodCall = $arg->value;
if (! $this->isName($methodCall->name, 'createMock')) {
continue;
}
$methodCall->name = new Identifier('createStub');
$hasChanges = true;
}
if ($hasChanges) {
return $node;
}
return null;
}
}