-
Notifications
You must be signed in to change notification settings - Fork 65
Expand file tree
/
Copy pathBehatPHPUnitAssertToWebmozzartRector.php
More file actions
202 lines (172 loc) · 5.6 KB
/
BehatPHPUnitAssertToWebmozzartRector.php
File metadata and controls
202 lines (172 loc) · 5.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
<?php
declare(strict_types=1);
namespace Rector\PHPUnit\CodeQuality\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\PHPStan\ScopeFetcher;
use Rector\PHPUnit\Enum\BehatClassName;
use Rector\PHPUnit\Enum\PHPUnitClassName;
use Rector\PHPUnit\Enum\WebmozartClassName;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\BehatPHPUnitAssertToWebmozzartRector\BehatPHPUnitAssertToWebmozzartRectorTest
*/
final class BehatPHPUnitAssertToWebmozzartRector extends AbstractRector
{
/**
* @var array<string, string>
*/
private const array PHPUNIT_TO_WEBMOZZART_METHODS = [
// Boolean
'assertTrue' => 'true',
'assertFalse' => 'false',
// Null / empty
'assertNull' => 'null',
'assertNotNull' => 'notNull',
'assertEmpty' => 'isEmpty',
'assertNotEmpty' => 'notEmpty',
// Type checks
'assertIsString' => 'string',
'assertIsInt' => 'integer',
'assertIsFloat' => 'float',
'assertIsBool' => 'boolean',
'assertIsArray' => 'isArray',
'assertIsObject' => 'object',
'assertIsCallable' => 'isCallable',
'assertIsResource' => 'resource',
'assertIsIterable' => 'isIterable',
'assertInstanceOf' => 'isInstanceOf',
// Comparison / equality
'assertSame' => 'same',
'assertNotSame' => 'notSame',
'assertEquals' => 'eq',
'assertNotEquals' => 'notEq',
'assertGreaterThan' => 'greaterThan',
'assertGreaterThanOrEqual' => 'greaterThanEq',
'assertLessThan' => 'lessThan',
'assertLessThanOrEqual' => 'lessThanEq',
// Strings
'assertStringContainsString' => 'contains',
'assertStringNotContainsString' => 'notContains',
'assertStringStartsWith' => 'startsWith',
'assertStringStartsNotWith' => 'notStartsWith',
'assertStringEndsWith' => 'endsWith',
'assertStringEndsNotWith' => 'notEndsWith',
'assertMatchesRegularExpression' => 'regex',
// Arrays / count
'assertCount' => 'count',
'assertArrayHasKey' => 'keyExists',
'assertArrayNotHasKey' => 'keyNotExists',
// Misc / less direct
'assertFileExists' => 'fileExists',
'assertFileIsReadable' => 'readable',
'assertDirectoryExists' => 'directory',
];
/**
* @var string[]
*/
private const array FLIPPED_ARGS = [
'assertSame',
'assertNotSame',
'assertEquals',
'assertNotEquals',
'assertGreaterThan',
'assertGreaterThanOrEqual',
'assertLessThan',
'assertLessThanOrEqual',
'assertCount',
'assertContains',
'assertNotContains',
];
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Change PHPUnit assert in Behat context files to Webmozart Assert, as first require a TestCase instance',
[
new CodeSample(
<<<'CODE_SAMPLE'
use Behat\Behat\Context\Context;
use PHPUnit\Framework\Assert;
final class SomeContext implements Context
{
public function someMethod()
{
Assert::assertSame('expected', 'actual');
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use Behat\Behat\Context\Context;
use Webmozart\Assert\Assert;
final class SomeContext implements Context
{
public function someMethod()
{
Assert::same('actual', 'expected');
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string>
*/
public function getNodeTypes(): array
{
return [ClassMethod::class];
}
/**
* @param ClassMethod $node
*/
public function refactor(Node $node): ?ClassMethod
{
$scope = ScopeFetcher::fetch($node);
if (! $scope->isInClass()) {
return null;
}
$classReflection = $scope->getClassReflection();
if (! $classReflection->is(BehatClassName::CONTEXT)) {
return null;
}
$hasChanged = false;
$this->traverseNodesWithCallable($node, function (Node $node) use (&$hasChanged): ?StaticCall {
if (! $node instanceof StaticCall) {
return null;
}
if (! $this->isName($node->class, PHPUnitClassName::ASSERT)) {
return null;
}
$phpunitMethodName = $this->getName($node->name);
if ($phpunitMethodName === null) {
return null;
}
// changed method name
$webmozartMethodName = self::PHPUNIT_TO_WEBMOZZART_METHODS[$phpunitMethodName] ?? null;
if ($webmozartMethodName === null) {
return null;
}
if (in_array($phpunitMethodName, self::FLIPPED_ARGS, true) && count($node->args) >= 2) {
// flip first 2 args
$temp = $node->args[0];
$node->args[0] = $node->args[1];
$node->args[1] = $temp;
}
$node->class = new FullyQualified(WebmozartClassName::ASSERT);
$node->name = new Identifier($webmozartMethodName);
$hasChanged = true;
return $node;
});
if (! $hasChanged) {
return null;
}
return $node;
}
}