-
Notifications
You must be signed in to change notification settings - Fork 65
Expand file tree
/
Copy pathAssertRegExpRector.php
More file actions
202 lines (166 loc) · 6.02 KB
/
AssertRegExpRector.php
File metadata and controls
202 lines (166 loc) · 6.02 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
<?php
declare(strict_types=1);
namespace Rector\PHPUnit\CodeQuality\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Identifier;
use PhpParser\Node\Scalar\Int_;
use PhpParser\Node\Stmt\Expression;
use Rector\Exception\ShouldNotHappenException;
use Rector\NodeManipulator\StmtsManipulator;
use Rector\PhpParser\Enum\NodeGroup;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertRegExpRector\AssertRegExpRectorTest
*/
final class AssertRegExpRector extends AbstractRector
{
/**
* @var string
*/
private const ASSERT_SAME = 'assertSame';
/**
* @var string
*/
private const ASSERT_EQUALS = 'assertEquals';
/**
* @var string
*/
private const ASSERT_NOT_SAME = 'assertNotSame';
/**
* @var string
*/
private const ASSERT_NOT_EQUALS = 'assertNotEquals';
public function __construct(
private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
private readonly ValueResolver $valueResolver,
private readonly StmtsManipulator $stmtsManipulator,
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Turns `preg_match` comparisons to their method name alternatives in PHPUnit TestCase',
[
new CodeSample(
'$this->assertSame(1, preg_match("/^Message for ".*"\.$/", $string), $message);',
'$this->assertRegExp("/^Message for ".*"\.$/", $string, $message);'
),
new CodeSample(
'$this->assertEquals(false, preg_match("/^Message for ".*"\.$/", $string), $message);',
'$this->assertNotRegExp("/^Message for ".*"\.$/", $string, $message);'
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return NodeGroup::STMTS_AWARE;
}
/**
* @param StmtsAware $node
*/
public function refactor(Node $node): ?Node
{
if ($node->stmts === null) {
return null;
}
$hasChanged = false;
foreach ($node->stmts as $key => $stmt) {
if (! $stmt instanceof Expression) {
continue;
}
if (! $stmt->expr instanceof MethodCall && ! $stmt->expr instanceof StaticCall) {
continue;
}
if (! $this->testsNodeAnalyzer->isPHPUnitMethodCallNames(
$stmt->expr,
[self::ASSERT_SAME, self::ASSERT_EQUALS, self::ASSERT_NOT_SAME, self::ASSERT_NOT_EQUALS]
)) {
continue;
}
if ($stmt->expr->isFirstClassCallable()) {
continue;
}
/** @var FuncCall|Node $secondArgumentValue */
$secondArgumentValue = $stmt->expr->getArgs()[1]
->value;
if (! $secondArgumentValue instanceof FuncCall) {
continue;
}
if (! $this->isName($secondArgumentValue, 'preg_match')) {
continue;
}
if ($secondArgumentValue->isFirstClassCallable()) {
continue;
}
$oldMethodName = $this->getName($stmt->expr->name);
if ($oldMethodName === null) {
continue;
}
$args = $secondArgumentValue->getArgs();
if (isset($args[2]) && $args[2]->value instanceof Variable && $this->stmtsManipulator->isVariableUsedInNextStmt(
$node,
$key + 1,
(string) $this->getName($args[2]->value)
)) {
continue;
}
$oldFirstArgument = $stmt->expr->getArgs()[0]
->value;
$oldCondition = $this->resolveOldCondition($oldFirstArgument);
$this->renameMethod($stmt->expr, $oldMethodName, $oldCondition);
$this->moveFunctionArgumentsUp($stmt->expr);
$hasChanged = true;
}
if ($hasChanged) {
return $node;
}
return null;
}
private function resolveOldCondition(Expr $expr): int
{
if ($expr instanceof Int_) {
return $expr->value;
}
if ($expr instanceof ConstFetch) {
return $this->valueResolver->isTrue($expr) ? 1 : 0;
}
throw new ShouldNotHappenException();
}
private function renameMethod(MethodCall|StaticCall $node, string $oldMethodName, int $oldCondition): void
{
if (in_array($oldMethodName, [self::ASSERT_SAME, self::ASSERT_EQUALS], true) && $oldCondition === 1
|| in_array($oldMethodName, [self::ASSERT_NOT_SAME, self::ASSERT_NOT_EQUALS], true) && $oldCondition === 0
) {
$node->name = new Identifier('assertRegExp');
}
if (in_array($oldMethodName, [self::ASSERT_SAME, self::ASSERT_EQUALS], true) && $oldCondition === 0
|| in_array($oldMethodName, [self::ASSERT_NOT_SAME, self::ASSERT_NOT_EQUALS], true) && $oldCondition === 1
) {
$node->name = new Identifier('assertNotRegExp');
}
}
private function moveFunctionArgumentsUp(MethodCall|StaticCall $node): void
{
$oldArguments = $node->getArgs();
/** @var FuncCall $pregMatchFunction */
$pregMatchFunction = $oldArguments[1]->value;
$regex = $pregMatchFunction->getArgs()[0];
$variable = $pregMatchFunction->getArgs()[1];
unset($oldArguments[0], $oldArguments[1]);
$node->args = [$regex, $variable, ...$oldArguments];
}
}