[ci-review] Rector Rectify

Author: actions-user

rules/CodeQuality/Rector/ClassMethod/AddInstanceofAssertForNullableInstanceRector.php

@@ -11,12 +11,14 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name\FullyQualified;
+use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Foreach_;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\UnionType;
 use Rector\PHPUnit\CodeQuality\ValueObject\VariableNameToType;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
@@ -159,7 +161,7 @@ public function refactor(Node $node): ?Node
 
     private function isNullableType(Type $type): bool
     {
-        if (! $type instanceof \PHPStan\Type\UnionType) {
+        if (! $type instanceof UnionType) {
             return false;
         }
 
@@ -217,12 +219,12 @@ private function matchNullableVariableNameToType(
     ): ?VariableNameToType {
         $variableName = $this->getName($variable);
 
-        foreach ($nullableVariableNamesToTypes as $nullableVariableNamesToType) {
-            if ($nullableVariableNamesToType->getVariableName() !== $variableName) {
+        foreach ($nullableVariableNamesToTypes as $nullableVariableNameToType) {
+            if ($nullableVariableNameToType->getVariableName() !== $variableName) {
                 continue;
             }
 
-            return $nullableVariableNamesToType;
+            return $nullableVariableNameToType;
         }
 
         return null;
@@ -232,15 +234,15 @@ private function matchNullableVariableNameToType(
      * @param VariableNameToType[] $variableNamesToTypes
      */
     private function matchedNullableVariableNameToType(
-        Node\Stmt $stmt,
+        Stmt $stmt,
         array $variableNamesToTypes
     ): ?VariableNameToType {
         $matchedNullableVariableNameToType = null;
 
         $this->traverseNodesWithCallable($stmt, function (Node $node) use (
             $variableNamesToTypes,
             &$matchedNullableVariableNameToType
-        ) {
+        ): null {
             if (! $node instanceof MethodCall) {
                 return null;
             }

rules/CodeQuality/ValueObject/VariableNameToType.php

@@ -4,11 +4,11 @@
 
 namespace Rector\PHPUnit\CodeQuality\ValueObject;
 
-final class VariableNameToType
+final readonly class VariableNameToType
 {
     public function __construct(
-        private readonly string $variableName,
-        private readonly string $objectType
+        private string $variableName,
+        private string $objectType
     ) {
     }