[CodeQuality] Skip new object instances in NarrowIdenticalWithConsecutiveRector (#726)

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/NarrowIdenticalWithConsecutiveRector/Fixture/skip_new_object.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\NarrowIdenticalWithConsecutiveRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\NarrowIdenticalWithConsecutiveRector\Source\SomeMockedClass;
+
+final class SkipNewObject extends TestCase
+{
+    public function test()
+    {
+        $someServiceMock = $this->createMock(SomeMockedClass::class);
+        $someServiceMock->expects($this->exactly(3))
+            ->method('prepare')
+            ->withConsecutive(
+                [new \stdClass()],
+                [new \stdClass()],
+                [new \stdClass()],
+            );
+    }
+}

rules/CodeQuality/Rector/MethodCall/NarrowIdenticalWithConsecutiveRector.php

@@ -7,8 +7,10 @@
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Identifier;
 use PhpParser\PrettyPrinter\Standard;
+use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -20,7 +22,8 @@
 final class NarrowIdenticalWithConsecutiveRector extends AbstractRector
 {
     public function __construct(
-        private readonly TestsNodeAnalyzer $testsNodeAnalyzer
+        private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
+        private readonly BetterNodeFinder $betterNodeFinder
     ) {
     }
 
@@ -104,6 +107,11 @@ public function refactor(Node $node): MethodCall|null
             return null;
         }
 
+        // skip new object instances, as each creates a fresh instance with possible property dependency
+        if ($this->betterNodeFinder->hasInstancesOf($node->getArgs(), [New_::class])) {
+            return null;
+        }
+
         $uniqueArgValues = $this->resolveUniqueArgValues($node);
 
         // multiple unique values