[PHPUnit90] Handle crash on different object without second arg on SpecificAssertContainsWithoutIdentityRector

samsonasik · samsonasik · commit 13555eff92fd · 2025-04-10T18:27:05.000+07:00
diff --git a/src/NodeAnalyzer/TestsNodeAnalyzer.php b/src/NodeAnalyzer/TestsNodeAnalyzer.php
@@ -34,10 +34,10 @@ public function __construct(
 
     public function isInTestClass(Node $node): bool
     {
-        if ($node->var instanceof Variable && $this->nodeNameResolver->isNames($node->var, ['this', 'self'])) {
-            $classReflection = $this->reflectionResolver->resolveClassReflection($node);
-        } else {
+        if ($node instanceof MethodCall && (! $node->var instanceof Variable || ! $this->nodeNameResolver->isNames($node->var, ['this', 'self']))) {
             $classReflection = $this->reflectionResolver->resolveClassReflectionSourceObject($node);
+        } else {
+            $classReflection = $this->reflectionResolver->resolveClassReflection($node);
         }
 
         if (! $classReflection instanceof ClassReflection) {

Original file line number	Diff line number	Diff line change
`@@ -34,10 +34,10 @@ public function __construct(`
`34`	`34`
`35`	`35`	`public function isInTestClass(Node $node): bool`
`36`	`36`	`{`
`37`		`- if ($node->var instanceof Variable && $this->nodeNameResolver->isNames($node->var, ['this', 'self'])) {`
`38`		`- $classReflection = $this->reflectionResolver->resolveClassReflection($node);`
`39`		`- } else {`
	`37`	`+ if ($node instanceof MethodCall && (! $node->var instanceof Variable \|\| ! $this->nodeNameResolver->isNames($node->var, ['this', 'self']))) {`
`40`	`38`	`$classReflection = $this->reflectionResolver->resolveClassReflectionSourceObject($node);`
	`39`	`+ } else {`
	`40`	`+ $classReflection = $this->reflectionResolver->resolveClassReflection($node);`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`if (! $classReflection instanceof ClassReflection) {`