[PHPUnit] Handle mix AssertCountWithZeroToAssertEmptyRector + AssertEmptyNullableObjectToAssertInstanceofRector cause invalid assertNotInstanceof() (#463)

* [PHPUnit] Handle mix AssertCountWithZeroToAssertEmptyRector + AssertEmptyNullableObjectToAssertInstanceofRector cause invalid assertNotInstanceof()

* Fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules/CodeQuality/Rector/MethodCall/AssertCountWithZeroToAssertEmptyRector.php

@@ -75,6 +75,11 @@ public function refactor(Node $node): MethodCall|StaticCall|null
             return null;
         }
 
+        $secondType = $this->getType($node->getArgs()[1]->value);
+        if ($secondType instanceof UnionType) {
+            return null;
+        }
+
         $value = ($type->getConstantScalarValues()[0] ?? null);
         if ($value === 0) {
             $args = $node->getArgs();

tests/Issues/EmptyUnion/EmptyUnionTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\Issues\EmptyUnion;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class EmptyUnionTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/EmptyUnion/Fixture/some_test.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\Issues\EmptyUnion\Fixture;
+
+use ArrayIterator;
+use PHPUnit\Framework\TestCase;
+
+final class SomeTest extends TestCase
+{
+    public function testSomething()
+    {
+        $this->assertCount(0, $this->someCall());
+    }
+
+    public function someCall(): ?ArrayIterator
+    {
+        return new ArrayIterator([]);
+    }
+}

tests/Issues/EmptyUnion/config/configured_rule.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertCountWithZeroToAssertEmptyRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([
+        AssertCountWithZeroToAssertEmptyRector::class,
+        AssertEmptyNullableObjectToAssertInstanceofRector::class,
+    ]);
+};