[CodeQuality] Fix assertGreater/Less apply on AssertComparisonToSpecificMethodRector (#532)

* Create assert_true_to_greater_than.php.inc

Fixture to test proper refactoring of PHPUnit assertion.

* Closes #531

* more

* more fixtures

* should keep order

---------

Co-authored-by: Artem Lopata <biozshock@gmail.com>

Author: samsonasik

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_true_to_greater_than.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertTrueToGreaterThan extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertTrue(0 > $param);
+        self::assertTrue(0 >= $param);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertTrueToGreaterThan extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertGreaterThan($param, 0);
+        self::assertGreaterThanOrEqual($param, 0);
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_true_to_less_than.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertTrueToLessThan extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertTrue(0 < $param);
+        self::assertTrue(0 <= $param);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertTrueToLessThan extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertLessThan($param, 0);
+        self::assertLessThanOrEqual($param, 0);
+    }
+}
+
+?>

rules/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector.php

@@ -122,22 +122,27 @@ private function processCallWithBinaryOp(MethodCall|StaticCall $node, BinaryOp $
                 'assertFalse' => $binaryOpWithAssertMethod->getNotAssertMethodName(),
             ]);
 
-            $this->changeArgumentsOrder($node);
+            $shouldKeepOrder = $binaryOp instanceof Greater
+                || $binaryOp instanceof GreaterOrEqual
+                || $binaryOp instanceof Smaller
+                || $binaryOp instanceof SmallerOrEqual;
+
+            $this->changeArgumentsOrder($node, $shouldKeepOrder);
 
             return $node;
         }
 
         return null;
     }
 
-    private function changeArgumentsOrder(MethodCall|StaticCall $node): void
+    private function changeArgumentsOrder(MethodCall|StaticCall $node, bool $shouldKeepOrder): void
     {
         $oldArguments = $node->getArgs();
 
         /** @var BinaryOp $expression */
         $expression = $oldArguments[0]->value;
 
-        if ($this->isConstantValue($expression->left)) {
+        if ($this->isConstantValue($expression->left) && ! $shouldKeepOrder) {
             $firstArgument = new Arg($expression->left);
             $secondArgument = new Arg($expression->right);
         } else {