📖 [9138] Explain fixture behavior with comment

andrew-demb · andrew-demb · commit 1980c36c8031 · 2025-05-02T13:40:20.000+02:00
rectorphp/rector#9138
diff --git a/rules-tests/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/include_exceptions.php.inc b/rules-tests/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector/Fixture/include_exceptions.php.inc
@@ -8,6 +8,7 @@ final class IncludeExceptions extends TestCase
 {
     public function testMe()
     {
+        // this calls should be preserved with $this, because methods are not static
         $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('foo');
         $this->expectExceptionCode(123);
@@ -26,6 +27,7 @@ final class IncludeExceptions extends TestCase
 {
     public function testMe()
     {
+        // this calls should be preserved with $this, because methods are not static
         $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('foo');
         $this->expectExceptionCode(123);

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ final class IncludeExceptions extends TestCase`
`8`	`8`	`{`
`9`	`9`	`public function testMe()`
`10`	`10`	`{`
	`11`	`+ // this calls should be preserved with $this, because methods are not static`
`11`	`12`	`$this->expectException(\RuntimeException::class);`
`12`	`13`	`$this->expectExceptionMessage('foo');`
`13`	`14`	`$this->expectExceptionCode(123);`
`@@ -26,6 +27,7 @@ final class IncludeExceptions extends TestCase`
`26`	`27`	`{`
`27`	`28`	`public function testMe()`
`28`	`29`	`{`
	`30`	`+ // this calls should be preserved with $this, because methods are not static`
`29`	`31`	`$this->expectException(\RuntimeException::class);`
`30`	`32`	`$this->expectExceptionMessage('foo');`
`31`	`33`	`$this->expectExceptionCode(123);`